Error using in typescript

[codyaray]

Getting this error when importing gdax

$ tsc gdax.ts
node_modules/gdax/index.d.ts(225,56): error TS1016: A required parameter cannot follow an optional parameter.

Commenting out this line makes this work:

cancelAllOrders(args?: { product_id: string }, callback: callback<string[]>): void;

Here's the gdax.ts file:

import Gdax = require('gdax');
const websocket = new Gdax.WebsocketClient(['BTC-USD', 'ETH-USD']);

websocket.on('message', data => {
  console.log(data);
});
websocket.on('error', err => {
  console.log(err);
});
websocket.on('close', () => {
  console.log('closing');
});

[blair]

Thanks for catching that, I can reproduce it. It's odd my copy didn't pick it up, I copied the file into my own project and tsc didn't (and still doesn't) complain.

The best fix is to probably make args required but make the product_id property optional.

[blair]

Can you try the PR here and see if it works for you: #303

[codyaray]

Thanks, #303 works for me. :)

[codyaray]

I'm running tsc 2.8.1, fwiw.

[fb55]

Fixed in #303. Thanks, @blair!

[Kurry]

@fb55 Can we leave this open until its published?

[fb55]

Published this as 0.8.0