Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciler End Condition #102

Merged
merged 10 commits into from
Aug 11, 2020
Merged

Reconciler End Condition #102

merged 10 commits into from
Aug 11, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 11, 2020

Changes

  • Store LastReconciled in BalanceStorage
  • Add coverage reconciler end condition
  • Log reconciliation coverage in check:data stats
  • Check failed: Transaction Conflict. -> BadgerDB does not support concurrent write transactions that modify the same key

@patrick-ogrady patrick-ogrady changed the title Reconciler End Condition [WIP] Reconciler End Condition Aug 11, 2020
@coveralls
Copy link

coveralls commented Aug 11, 2020

Pull Request Test Coverage Report for Build 3519

  • 93 of 117 (79.49%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 71.689%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/storage/block_storage.go 4 5 80.0%
pkg/storage/badger_storage.go 20 22 90.91%
pkg/storage/balance_storage.go 48 69 69.57%
Totals Coverage Status
Change from base Build 3440: 0.4%
Covered Lines: 1727
Relevant Lines: 2409

💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title [WIP] Reconciler End Condition Reconciler End Condition Aug 11, 2020
@@ -142,6 +142,6 @@ var versionCmd = &cobra.Command{
Use: "version",
Short: "Print rosetta-cli version",
Run: func(cmd *cobra.Command, args []string) {
fmt.Println("v0.4.2-beta-101")
fmt.Println("v0.4.2-beta-102")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helps with debugging for teams that use master

@patrick-ogrady patrick-ogrady requested review from yfl92, qiwu7, a team and juliankoh August 11, 2020 23:01
Copy link

@yfl92 yfl92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@patrick-ogrady patrick-ogrady merged commit d6cf79a into master Aug 11, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/reconciler-end branch August 11, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants