-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconciler End Condition #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
changed the title
Reconciler End Condition
[WIP] Reconciler End Condition
Aug 11, 2020
Pull Request Test Coverage Report for Build 3519
💛 - Coveralls |
patrick-ogrady
changed the title
[WIP] Reconciler End Condition
Reconciler End Condition
Aug 11, 2020
patrick-ogrady
commented
Aug 11, 2020
@@ -142,6 +142,6 @@ var versionCmd = &cobra.Command{ | |||
Use: "version", | |||
Short: "Print rosetta-cli version", | |||
Run: func(cmd *cobra.Command, args []string) { | |||
fmt.Println("v0.4.2-beta-101") | |||
fmt.Println("v0.4.2-beta-102") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helps with debugging for teams that use master
yfl92
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LastReconciled
inBalanceStorage
check:data
statsCheck failed: Transaction Conflict.
-> BadgerDB does not support concurrent write transactions that modify the same key