Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Processor] Verbose Construction API Logging #144

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Sep 30, 2020

This PR exposes the ability to print all requests made to the Construction API. This can help significantly with debugging errors!

image

Changes

  • log all requests, responses, and errors when interacting with the Construction API
  • Add quiet option to configuration to disable verbose logging
  • Add arg names to verbose logs

@heimdall-asguard
Copy link

If Heimdall is stuck, please click the following link: https://heimdall-public.cbhq.net/v1/pull_request/stuck?pr_number=144&repository=coinbase/rosetta-cli

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5037

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.279%

Totals Coverage Status
Change from base Build 5019: 0.0%
Covered Lines: 168
Relevant Lines: 197

💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit c327f12 into master Sep 30, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/verbose-construction-api branch September 30, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants