Replace broken link for commit guidelines #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If Heimdall is stuck, please click the following link: https://heimdall-public.cbhq.net/v1/pull_request/stuck?pr_number=151&repository=coinbase/rosetta-cli |
patrick-ogrady
approved these changes
Oct 5, 2020
|
@KNWR Looks like you'll need to sign your commit before I can review 😢 |
|
On it 👍 |
KNWR
force-pushed
the
kanwar/fix-broken-contributing-link
branch
from
ab946e3
to
ab909f0
Compare
patrick-ogrady
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The contribution guidelines suggest that contributors
Ensure your [commit messages are well-written](https://medium.com/brigade-engineering/the-secrets-to-great-commit-messages-106fc0a92a25).The medium link redirects to an expired domain.
Solution
This PR replaces the broken link with a link to similar guidelines suggested by patrick-ogrady : https://chris.beams.io/posts/git-commit/#seven-rules
I'm opening PRs to make this fix in these repos: rosetta-specifications, rosetta-cli, rosetta-sdk-go and rosetta-bitcoin.