Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logging] Expose Reconciler Queue Size + Last Checked #165

Merged
merged 4 commits into from
Oct 15, 2020
Merged

[Logging] Expose Reconciler Queue Size + Last Checked #165

merged 4 commits into from
Oct 15, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Oct 15, 2020 •
edited
Loading

Related: coinbase/mesh-sdk-go#187

This PR exposes new reconciler information (QueueSize and LastIndexReconciled) in the check:data status endpoint.

Changes

  • Update rosetta-cli version
  • Add logging changes
  • Update to new rosetta-sdk-go release

@heimdall-asguard
Copy link

If Heimdall is stuck, please click the following link: https://heimdall-public.cbhq.net/v1/pull_request/stuck?pr_number=165&repository=coinbase/rosetta-cli

@patrick-ogrady patrick-ogrady requested a review from yfl92 October 15, 2020 16:02
@coveralls
Copy link

coveralls commented Oct 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 5480

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.408%
Totals Coverage Status
Change from base Build 5452: 0.0%
Covered Lines: 186
Relevant Lines: 223
💛 - Coveralls

@heimdall-asguard
Copy link

Review Error for yflinn @ 2020-10-15 17:10:02 UTC
User failed mfa authentication, see go/mfa-help

@patrick-ogrady patrick-ogrady merged commit e38b181 into master Oct 15, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/expose-queue-size branch October 15, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

@annieke annieke Awaiting requested review from annieke

@cindyxkuang cindyxkuang Awaiting requested review from cindyxkuang

@juliankoh juliankoh Awaiting requested review from juliankoh

@qiwu7 qiwu7 Awaiting requested review from qiwu7

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrick-ogrady @heimdall-asguard @coveralls @yfl92