Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Pruning Support #166

Merged
merged 7 commits into from
Oct 15, 2020
Merged

Dynamic Pruning Support #166

merged 7 commits into from
Oct 15, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Oct 15, 2020 •
edited
Loading

This PR adds support for new performance options meant to vastly improve syncing speed on the check:data command.

Changes

  • Add dynamic pruning (to support reconciliation backlog)
  • Add new optional performance options (compression_disabled and memory_limit_disabled)
  • Update to rosetta-sdk-go@v0.5.4

@heimdall-asguard
Copy link

If Heimdall is stuck, please click the following link: https://heimdall-public.cbhq.net/v1/pull_request/stuck?pr_number=166&repository=coinbase/rosetta-cli

@coveralls
Copy link

coveralls commented Oct 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 5527

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.408%
Totals Coverage Status
Change from base Build 5488: 0.0%
Covered Lines: 186
Relevant Lines: 223
💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 68b51fd into master Oct 15, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/dynamic-pruning branch October 15, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

@qiwu7 qiwu7 Awaiting requested review from qiwu7

@cindyxkuang cindyxkuang Awaiting requested review from cindyxkuang

@annieke annieke Awaiting requested review from annieke

@juliankoh juliankoh Awaiting requested review from juliankoh

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrick-ogrady @heimdall-asguard @coveralls @yfl92