Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reconciler] Lookup by Index + Orphan Race Condition Fix #177

Merged
merged 8 commits into from
Oct 29, 2020
Merged

[reconciler] Lookup by Index + Orphan Race Condition Fix #177

merged 8 commits into from
Oct 29, 2020

Conversation

patrick-ogrady
Copy link
Contributor

Related: coinbase/mesh-sdk-go#213
Related: coinbase/mesh-sdk-go#214

This PR updates rosetta-sdk-go to fix a potential race condition in the reconciler.

Changelog

  • Update verison
  • Update rosetta-sdk-go
  • Update pkg to reflect reconciler interface changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5907

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.408%
Totals Coverage Status
Change from base Build 5864: 0.0%
Covered Lines: 186
Relevant Lines: 223
💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 6c384a2 into master Oct 29, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/reconciler-fix branch October 29, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjun-io arjun-io arjun-io approved these changes

@qiwu7 qiwu7 Awaiting requested review from qiwu7

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @arjun-io