Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check:data with bootstrap balance resume panic #95

Merged
merged 1 commit into from
Aug 8, 2020
Merged

fix check:data with bootstrap balance resume panic #95

merged 1 commit into from
Aug 8, 2020

Conversation

yutongp
Copy link
Contributor

@yutongp yutongp commented Aug 7, 2020

Fixes #90

patrick-ogrady
patrick-ogrady approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! We need better coverage in this file 😢

@patrick-ogrady patrick-ogrady merged commit 56a11cd into coinbase:master Aug 8, 2020
@yutongp yutongp deleted the yutong/fix_panic_d branch August 8, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic on resuming check:data v0.4.0
2 participants
@yutongp @patrick-ogrady