[chore] Update msgpack #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
commented
Nov 23, 2020
| @@ -84,7 +88,7 @@ func NewEncoder( | |||
|
|
|||
| func getEncoder(w io.Writer) *msgpack.Encoder { | |||
| enc := msgpack.NewEncoder(w) | |||
| enc.UseJSONTag(true) | |||
| enc.SetCustomStructTag(jsonTag) | |||
There was a problem hiding this comment.
the msgpack api changed 😢
patrick-ogrady
requested review from
alex-stone,
arjun-io,
bobg,
cindyxkuang,
itstehkman,
septerr and
yfl92
Pull Request Test Coverage Report for Build 11918
💛 - Coveralls |
septerr
approved these changes
Nov 23, 2020
|
Review Error for septerr @ 2020-11-23 18:10:40 UTC |
septerr
approved these changes
Nov 23, 2020
|
Review Error for septerr @ 2020-11-23 18:14:31 UTC |
bobg
approved these changes
Nov 23, 2020
septerr
approved these changes
Nov 23, 2020
|
Review Error for septerr @ 2020-11-23 18:23:47 UTC |
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #243
This PR updates
msgpackto the latest release and resolves breaking API changes.