Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return ops instead of indicies #36

Merged
merged 2 commits into from
May 22, 2020
Merged

Return ops instead of indicies #36

merged 2 commits into from
May 22, 2020

Conversation

patrick-ogrady
Copy link
Contributor

Motivation

Fixes #35

Solution

Return []*types.Operation from MatchOperations instead of []int.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1492

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 65.793%
Totals Coverage Status
Change from base Build 1475: -0.05%
Covered Lines: 1431
Relevant Lines: 2175
💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 24b455a into master May 22, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/return-matched-ops branch May 22, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brockmiller brockmiller brockmiller approved these changes

@annieke annieke Awaiting requested review from annieke

@niallo niallo Awaiting requested review from niallo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return Matching Operations Instead of Matches
3 participants
@patrick-ogrady @coveralls @brockmiller