Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Fixes Before Release #63

Merged
merged 5 commits into from
Jul 13, 2020
Merged

Miscellaneous Fixes Before Release #63

merged 5 commits into from
Jul 13, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 12, 2020 •
edited
Loading

Changes

  • Update README links to new website
  • Change KeyPair to get rid of redundant CurveType usage
  • Change ed25519 signer to edwards25519 signer

@patrick-ogrady patrick-ogrady requested review from juliankoh and a team July 13, 2020 04:52
niallo
niallo previously approved these changes Jul 13, 2020
View reviewed changes
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2429

  • 25 of 33 (75.76%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 65.737%
Changes Missing Coverage Covered Lines Changed/Added Lines %
keys/keys.go 16 18 88.89%
keys/types.go 5 11 45.45%
Totals Coverage Status
Change from base Build 2389: -0.07%
Covered Lines: 1863
Relevant Lines: 2834
💛 - Coveralls

@patrick-ogrady patrick-ogrady requested review from niallo, yfl92 and a team July 13, 2020 05:05
@patrick-ogrady patrick-ogrady merged commit 6fcf086 into master Jul 13, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/misc-fixes branch July 13, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

@juliankoh juliankoh Awaiting requested review from juliankoh

@niallo niallo Awaiting requested review from niallo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrick-ogrady @coveralls @niallo @yfl92