Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise optional warning for missing property keys #34

Open
jvita opened this issue Oct 10, 2024 · 0 comments
Open

Raise optional warning for missing property keys #34

jvita opened this issue Oct 10, 2024 · 0 comments

Comments

@jvita
Copy link
Member

jvita commented Oct 10, 2024

It can be challenging to debug issues caused by an incorrectly formatted property_map or missing property keys when uploading data. Currently, adding data will silently "fail" -- no indication is provided that the properties were not actually added.

This is due to the continue statement here. A better alternative may be to change this line to generate an error message that counts how many configurations had missing keys, which is then logged at the end of the loop. This would make it much easier to recognize when there may be something wrong during data upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant