Windows doesn't like the log_disabled symlink

[azriel91]

Hiya, just discovered that on Windows, the log_disabled.rs symlink isn't happily interpreted, so it fails to build when the "logging" feature is disabled (which is the default).

Error message:

error[E0583]: file not found for module `log_disabled`
   --> D:\apps\gitlab_runner\.cargo\git\checkouts\rust-derive-builder-ac2766f218331415\67c9c95\derive_builder\src\lib.rs:576:5
    |
576 | mod log_disabled;
    |     ^^^^^^^^^^^^
    |
    = help: name the file either log_disabled.rs or log_disabled\mod.rs inside the directory "D:\apps\gitlab_runner\.cargo\git\checkouts\rust-derive-builder-ac2766f218331415\67c9c95\derive_builder\src"

I haven't thought of a solution that I like, though to "make it work ™️" one could:

• enable the "logging" feature
• copy paste the file in here
• somehow convince every windows CI machine to follow the symlink

_{software: 1, humans: 0}

[azriel91]

Figured it out. A crate with derive_builder = "0.8.0" in its dependencies works. But a crate with the following doesn't:

derive_builder = { git = "https://github.com/colin-kiegel/rust-derive-builder.git" }

Both my user and the CI user have this:

$ git --version
git version 2.23.0.windows.1

$ git config core.symlinks
true

So it looks like Cargo doesn't enable core.symlinks on windows for git dependencies. Shall follow up with an issue there.