Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move colisLexer and colisParser back where they belong #10

Closed
Niols opened this issue Oct 4, 2018 · 2 comments · Fixed by #49
Closed

Move colisLexer and colisParser back where they belong #10

Niols opened this issue Oct 4, 2018 · 2 comments · Fixed by #49
Labels
waiting

Comments

@Niols
Copy link
Member

Niols commented Oct 4, 2018

This was blocked by an issue in Dune (ocaml/dune#1372) which is now fixed. However, fixing it in this project would mean that we require the last version of Dune (and probably the development version). This issue is here to remind us that some day later, we should fix it.
@Niols
Copy link
Member Author

Niols commented Oct 4, 2018

By the way, for our future selves, here are the changes to make:

  • move colisLexer and colisParser into src/language
  • probably move (ocamllex ...) and (menhir ...) stanzas from src/dune to src/language/dune.

@Niols Niols changed the title Move colisLexer and colisParser where they belong Move colisLexer and colisParser back where they belong Oct 11, 2018
@Niols Niols added the waiting label Oct 11, 2018
@Niols
Copy link
Member Author

Niols commented Dec 3, 2018

Just a small note. The version of Dune including the required fix is 1.4.0. We probably want to wait for it to reach Debian testing before fixing this issue.

@Niols Niols mentioned this issue Jan 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move lexer and parser back where they belong colis-anr/colis-language
1 participant
@Niols