Maximum call stack size exceeded with video.js 6.7.2

[zeusworkspace]

I getting this error on console when the player is loaded.

[thijstriemstra]

@devaptas what browser? what version of videojs-record, video.js? What does your player config look like? How am I supposed to debug this without any additional information?

[zeusworkspace]

Chrome Version 64.0.3282.167, viodejs-record 2.1.0, video.js 6.7.2, follow the config:

    var player, mediaOptions;

    if(isVideo) {
        var player = videojs('componentRecord',
        {
            //video.js options
            controls: true,
            width: 600,
            height: 300,
            plugins: {
                // videojs-record plugin options
                record: {
                    audio: true,
                    video: true,
                    maxLength: 1800,
                    debug: true
                }
            }
        });
        
        mediaOptions = {           
            tag: 'video',
            type: 'video/webm',
            ext: '.mp4',
            gUM: {video: true, audio: true}            
        };
    } else {
        var player = videojs('componentRecord',
        {
            controls: true,
            width: 600,
            height: 300,
            language: 'pt-BR',
            plugins: {
                wavesurfer: {
                    src: 'live',
                    waveColor: 'black',
                    progressColor: '#fff',
                    debug: true,
                    cursorWidth: 1,
                    msDisplayMax: 20,
                    hideScrollbar: true
                },
                record: {
                    audio: true,
                    video: false,
                    maxLength: 1800,                    
                    debug: true
                }
            }
        });
        
        mediaOptions = {
            tag: 'audio',
            type: 'audio/mp3',
            ext: '.mp3',
            gUM: {audio: true}            
        };
    }
    
    /* -------------  Trigger the vjs-device-button button ----------------- */
    player.on('ready', function(){
        player.recorder.getDevice();
    });

    player.on('deviceReady', function(){
        $('.vjs-record-button').attr('title', '". Yii::t('app', 'Start Record')."');

        // Waveform has to play just when recording
        if(!isVideo)
            player.waveform.pause();
    });

[thijstriemstra]

@devaptas I think video.js 6.7.2 is the issue, use 6.6.3 instead. I'll take a look at 6.7.2 support.

[zeusworkspace]

solved, tnks. So, I think the best solution is lock the video.js version on package.json, bower.json. I'm using the Asset Packagist to download the packages and it auto-check and download dependencies from this files.

[thijstriemstra]

@devaptas finding the issue, fixing it and putting out a new release should be probably just as fast. Also note that video.js >= 6.7.0 are marked as pre-releases..

[thijstriemstra]

And @devaptas this is probably only happening for audio-only?

[zeusworkspace]

both

[thijstriemstra]

Here's the diff for changes in 6.7: videojs/video.js@v6.6.3...v6.7.2

The bug also exists in videojs-wavesurfer (and should be fixed first): collab-project/videojs-wavesurfer#49

[thijstriemstra]

Fixed with 869eb86