Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable PIP button #486

Closed
Cicno opened this issue Jun 14, 2020 · 4 comments · Fixed by #555
Closed

Cannot disable PIP button #486

Cicno opened this issue Jun 14, 2020 · 4 comments · Fixed by #555
Labels

Comments

@Cicno
Copy link

Cicno commented Jun 14, 2020

Hi, I'm trying to set some options and it's not working. I've tried many things, but the options doesn't work, here is my code:

var options = {
    controls: true,
    bigPlayButton: false,
    loop: false,
    width: 320,
    height: 240,
    fluid: true,
    frameWidth: 320,
    frameHeight: 240,
    plugins: {
        record: {
            muted: false,
            audio: true,
            video: true,
            maxLength: 10,
            debug: true,
            videoMimeType: 	'video/webm;codecs=vp9',
            videoRecorderType: 'auto',
            videoFrameRate: 20,
            displayMilliseconds: false,
            pip: false
        },
    },
    controlBar: {
        // hide fullscreen and volume controls
        volumePanel: false,
        recordToggle: false,
        deviceButton: false,
        cameraButton: false,
        fullscreenToggle: false
    },
    video: {
        // video media constraints: set resolution of camera
        width: 320,
        height: 240
    }
};

1- The video options to change set resolution of camera, is not changing anything
2- The pip true or false doesn't hide the button
3- The frame rate doesn't change if I put 1 or 200

I don't see any error at JavaScript, but the options are not working, these options are not working or I'm doing something wrong?

@thijstriemstra
Copy link
Member

The video options to change set resolution of camera, is not changing anything

Use constraints, see https://collab-project.github.io/videojs-record/#/media-constraints

2- The pip true or false doesn't hide the button

You didn't include information about operating system, video.js version, browser version etc. Why not?

The frame rate doesn't change if I put 1 or 200

videoFrameRate option is only available when using the webm-wasm plugin.

@Cicno
Copy link
Author

Cicno commented Jun 15, 2020

The video options to change set resolution of camera, is not changing anything

Use constraints, see https://collab-project.github.io/videojs-record/#/media-constraints

It worked! Thank you!!!

2- The pip true or false doesn't hide the button

You didn't include information about operating system, video.js version, browser version etc. Why not?

ops, sorry. I'm using windows, the browser is chrome and opera. For firefox it's working

image - Opera

image Chrome

image -Firefox

The frame rate doesn't change if I put 1 or 200

videoFrameRate option is only available when using the webm-wasm plugin.

It worked too :)

@thijstriemstra
Copy link
Member

Not being able to disable pip is a bug, will look into it.

@thijstriemstra thijstriemstra changed the title Frame rate, pip and camera resolution is not working Cannot disable PIP button Jun 15, 2020
@thijstriemstra
Copy link
Member

thijstriemstra commented Mar 3, 2021

ops, sorry. I'm using windows, the browser is chrome and opera. For firefox it's working

I tested this on browsers below using videojs-record 4.2.0 and video.js 7.11.4:

Platform Browser Has bug
MacOS 11.2.2 Firefox 86 No (no pip support)
MacOS 11.2.2 Chrome 89.0.4389.72 Yes
MacOS 11.2.2 Safari 89.0.4389.72 Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants