Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function/class never tested #90

Closed
wants to merge 2 commits into from
Closed

Function/class never tested #90

wants to merge 2 commits into from

Conversation

Felice644
Copy link
Collaborator

@Felice644 Felice644 added the code Improvements or additions to code label May 19, 2022
@Felice644 Felice644 requested a review from louieQ May 19, 2022 20:43
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022 •
edited
Loading

Codecov Report

Merging #90 (de999b1) into master (cbfaf38) will increase coverage by 0.27%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   52.63%   52.90%   +0.27%     
==========================================
  Files          18       18              
  Lines         893      913      +20     
==========================================
+ Hits          470      483      +13     
- Misses        423      430       +7
Flag Coverage Δ
pytest 52.90% <65.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pynblint/repository.py 30.00% <16.66%> (-1.25%) ⬇️
pynblint/nb_linting.py 80.39% <81.81%> (+0.17%) ⬆️
tests/unit/test_nb_linting_functions.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@louieQ louieQ mentioned this pull request May 22, 2022
Merged
@louieQ louieQ added enhancement New feature or request wontfix This will not be worked on linting rule A new check performed by pynblint and removed code Improvements or additions to code enhancement New feature or request labels May 22, 2022
@louieQ louieQ closed this May 23, 2022
@louieQ louieQ deleted the function/class_never_tested branch May 23, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louieQ louieQ Awaiting requested review from louieQ

Assignees
No one assigned
Labels
linting rule A new check performed by pynblint wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect the definition of functions or class methods that are never tested
3 participants
@Felice644 @codecov-commenter @louieQ