-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of collective.js.jqueryui dependency #851
Comments
collective.js.jqueryui is now compatible with Python 3: collective/collective.js.jqueryui#40 we must pin >= 2.1.2. |
seems collective.js.jqueryui is still not fully compatible with Plone 5.2; when installing collective.cover I get the following error: Traceback (innermost last):
Module ZPublisher.WSGIPublisher, line 128, in transaction_pubevents
Module ZPublisher.WSGIPublisher, line 276, in publish_module
Module ZPublisher.WSGIPublisher, line 210, in publish
Module ZPublisher.mapply, line 85, in mapply
Module ZPublisher.WSGIPublisher, line 57, in call_object
Module Products.CMFPlone.controlpanel.browser.quickinstaller, line 689, in __call__
Module Products.CMFPlone.controlpanel.browser.quickinstaller, line 454, in install_product
Module Products.GenericSetup.tool, line 391, in runAllImportStepsFromProfile
- __traceback_info__: profile-collective.cover:default
Module Products.GenericSetup.tool, line 1463, in _runImportStepsFromContext
Module Products.GenericSetup.tool, line 1275, in _doRunImportStep
- __traceback_info__: plone.app.registry
Module plone.app.registry.exportimport.handler, line 79, in importRegistry
- __traceback_info__: registry.xml
Module plone.app.registry.exportimport.handler, line 127, in importDocument
Module plone.app.registry.exportimport.handler, line 414, in importRecords
- __traceback_info__: records name: collective.js.jqueryui.controlpanel.IJQueryUIPlugins
Module plone.app.registry.exportimport.handler, line 331, in importRecord
- __traceback_info__: record name: collective.js.jqueryui.controlpanel.IJQueryUIPlugins.ui_core
Module plone.registry.record, line 90, in _set_value
Module zope.event, line 32, in notify
Module zope.component.event, line 27, in dispatch
Module zope.component._api, line 124, in subscribers
Module zope.interface.registry, line 442, in subscribers
Module zope.interface.adapter, line 607, in subscribers
Module plone.registry.events, line 62, in redispatchInterfaceAwareRecordEvents
Module zope.component._api, line 124, in subscribers
Module zope.interface.registry, line 442, in subscribers
Module zope.interface.adapter, line 607, in subscribers
Module collective.js.jqueryui.controlpanel, line 290, in cook_js_resources
AttributeError: 'RequestContainer' object has no attribute 'portal_javascripts' |
Well, maybe we can make |
it doesn't make sense; you have Webpack now and a lot of new resources to develop in JS. we better get rid of jQuery. |
What I'm thinking is to reduce conflicts in portals that use |
it doesn't matter; just remove the dependency of cover on this package. you can follow the same approach we did when removing, for instance, the dependency on obviously this has more work involved because you need to replace what is done with jQueryUI with some custom JS code, but is not too difficult and in the long run is the way to go. what @rodfersou and I were thinking at the time was to use Vue to rewrite all the UI code of this package. I think jQueryUI is just used on a couple of places on the UI. |
collective.js.jqueryui is not compatible with Python 3; we need to get rid of this dependency.
The text was updated successfully, but these errors were encountered: