Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page with glossary term loses content upon opening in edit mode #29

Open
dgroos opened this issue Oct 6, 2016 · 4 comments
Open

Page with glossary term loses content upon opening in edit mode #29

dgroos opened this issue Oct 6, 2016 · 4 comments

Comments

@dgroos
Copy link

dgroos commented Oct 6, 2016

As described here: https://community.plone.org/t/page-content-disappears-upon-opening-in-edit-mode/2775
the content of a page containing a term in the glossary 'disappears' when opening the page in edit mode. An example of the offending tag/content is:
<abbr class="glossarizer_replaced" title="better than the rest"><abbr class="glossarizer_replaced">best</abbr></abbr>
I was able to reproduce this by copying and pasting this on a fresh plone 5.0.5 page, also by creating a fresh plone page, then adding a term from the glossary.

@hvelarde
Copy link
Member

hvelarde commented Oct 7, 2016

@dgroos thanks for reporting this; do you mind describing step-by-step what we need to do to reproduce the problem?

@dgroos
Copy link
Author

dgroos commented Oct 29, 2016

@hvelarde sorry took so long to get back to this--first free moment I've had...
Here's some setup info:
Plone 5.0.5 (5015)
CMF 2.2.10
Zope 2.13.24
Python 2.7.6 (default, Jun 22 2015, 17:58:13) [GCC 4.8.2]
PIL 3.1.1 (Pillow)
linux2
/usr/local/Plone/buildout-cache/eggs/collective.glossary-1.0a1-py2.7.egg

  1. Added the word "test" to an existing page.
  2. Added a term, "test" to the glossary (which was private, also left the term private).
  3. Refreshed existing page and word "test" was not underlined.
  4. Published the term, "test" (but not the whole glossary).
  5. Refreshed the existing page and the word "test" was underlined.
  6. Pressed edit on the existing page and when it opened up, all content was gone. I pressed cancel.

Is there more info that I could provide?

@hvelarde
Copy link
Member

hvelarde commented Oct 31, 2016

@dgroos I just fixed an issue with the JS code that was breaking the site (5b2ceb1); after that I was able to reproduce the issue in Plone 5 and seems to me like a bug there.

as you can see in the code used to register the JS, it should only load in certain states; that is, we do not load the glossarizer in the edit view, but that is not working on Plone 5.

I opened an issue there (plone/Products.CMFPlone#1821) but I think is going to be difficult to fix and I see no interest on keep working on that now that was decided to deprecate the legacy bundle on Plone 5.1.

sorry, but we have no time/resources to fix this as we are not using this package with Plone 5; if you can help, let me know.

@dgroos
Copy link
Author

dgroos commented Oct 31, 2016

@hvelarde Thanks for looking into this. Makes sense not to fix plone bug if that aspect is soon to be deprecated as Plone moves onto 5.1 but is unfortunate.

The kind of support I could give at this time would be testing or writing some documentation, neither of which will fix this bug or move the code further. However, let me know if this would be helpful at some point. Thanks for picking up and carrying this project forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants