Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n sync error #63

Closed
Fosten opened this issue Feb 14, 2023 · 3 comments · Fixed by plone/volto#4737
Closed

i18n sync error #63

Fosten opened this issue Feb 14, 2023 · 3 comments · Fixed by plone/volto#4737

Comments

@Fosten
Copy link
Contributor

Fosten commented Feb 14, 2023

Frontend GHA build fails with i18n sync error on first run.

After running the command 'make i18n' and pushing the new volto.po files to a repo, GHA builds successfully.

This is required to update the "POT-Creation-Date: 2023-02-13T23:02:51.976Z\n" timestamps.
@stevepiercy
Copy link
Member

Can this be automated? If not, then documenting the process would be the best course of action.

@ericof
Copy link
Member

ericof commented Feb 14, 2023

Imo, this should be a pre-commit hook.

@stevepiercy
Copy link
Member

pre-commit works for me. However we need to ensure that it is either installed by the cookiecutter or specified as a pre-requisite in the documentation.

@davisagli davisagli mentioned this issue May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix whitespace in locales created by the generator plone/volto
3 participants
@stevepiercy @ericof @Fosten