Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing / broken Membrane (user-) group support #17

Open
petri opened this issue Apr 16, 2016 · 4 comments
Open

Missing / broken Membrane (user-) group support #17

petri opened this issue Apr 16, 2016 · 4 comments
Labels
bug enhancement

Comments

@petri
Copy link
Member

petri commented Apr 16, 2016 •
edited
Loading

  • wrong group behavior factory in configure.zcml
  • there is no adapter from IMembraneGroup to IGroup
@petri petri changed the title Membrane (user-) group support is broken Missing / broken Membrane (user-) group support Apr 16, 2016
@petri
Copy link
Member Author

petri commented Apr 27, 2016

See petri-fix-group branch for an attempt to improve the membrane group support.

@gforcada
Copy link
Member

@petri you can create pull requests from your branch so it is easier to track the changes and review them.

@petri
Copy link
Member Author

petri commented Apr 28, 2016

Yes. Just wanted to tidy up a bit first. You can get a nice review view without PR, too, such as: https://github.com/collective/dexterity.membrane/compare/petri-fix-group

@petri petri mentioned this issue Apr 28, 2016
Open
@petri
Copy link
Member Author

petri commented Jun 8, 2016

@gforcada , any others, could you review the PR?

@mauritsvanrees mauritsvanrees mentioned this issue May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petri @gforcada