-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BYWEEKDAY #268
Comments
@natashamm Thanks for working on this issue! I wonder: Do you think that this issue can be closed now? Is there anything else to do? |
The other issue I was thinking of is: what if someone generates an RRULE with BYDAY and BYWEEKDAY, do we want to throw an error or automatically replace one with the other? From what I understand about icalendar, I would say no. If that is OK then I would say we can close the issue! |
Since it is an assumption of the algorithm, I would say an assertion would do it.
|
@natashamm @jonocodes #511 was merged and released in v5.0.5. Can you check if this can be closed? |
My bad - do you mean an assumption in https://dateutil.readthedocs.io/en/stable/rrule.html? |
No. If we have these two arguments that mean the same and the value differs, what do we do? Which one is used? rrule can only take one of them, I assume. What are your thoughts? |
Ok, thanks! I had a look. It seems that dateutil will handle the parsing of an rrule string and as such the question of how to convert this parameter is not necessary to answer in icalendar. Thanks for the work! |
dateutils.rrule supports the byweekday parameter already:
http://dateutil.readthedocs.io/en/stable/rrule.html
Could this be added to icalendar?
The text was updated successfully, but these errors were encountered: