Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BYWEEKDAY #268

Closed
jonocodes opened this issue Aug 13, 2018 · 7 comments
Closed

Add support for BYWEEKDAY #268

jonocodes opened this issue Aug 13, 2018 · 7 comments

Comments

@jonocodes
Copy link

dateutils.rrule supports the byweekday parameter already:
http://dateutil.readthedocs.io/en/stable/rrule.html

Could this be added to icalendar?

@niccokunzmann
Copy link
Member

@natashamm Thanks for working on this issue! I wonder: Do you think that this issue can be closed now? Is there anything else to do?

@natashamm
Copy link
Contributor

natashamm commented Feb 6, 2023

The other issue I was thinking of is: what if someone generates an RRULE with BYDAY and BYWEEKDAY, do we want to throw an error or automatically replace one with the other? From what I understand about icalendar, I would say no.

If that is OK then I would say we can close the issue!

@niccokunzmann
Copy link
Member

niccokunzmann commented Mar 23, 2023 via email

@niccokunzmann
Copy link
Member

@natashamm @jonocodes #511 was merged and released in v5.0.5. Can you check if this can be closed?

@natashamm
Copy link
Contributor

Since it is an assumption of the algorithm, I would say an assertion would do it.

My bad - do you mean an assumption in https://dateutil.readthedocs.io/en/stable/rrule.html?

@niccokunzmann
Copy link
Member

niccokunzmann commented Aug 2, 2023

No. If we have these two arguments that mean the same and the value differs, what do we do? Which one is used? rrule can only take one of them, I assume. What are your thoughts?

@niccokunzmann
Copy link
Member

Ok, thanks! I had a look. It seems that dateutil will handle the parsing of an rrule string and as such the question of how to convert this parameter is not necessary to answer in icalendar. Thanks for the work!
If there is any doubt whether this should be closed, please comment/re-open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants