Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_issue_335_identify_UTC fails? #397

Closed
jacadzaca opened this issue Sep 8, 2022 · 3 comments · Fixed by #414
Closed

test_issue_335_identify_UTC fails? #397

jacadzaca opened this issue Sep 8, 2022 · 3 comments · Fixed by #414

Comments

@jacadzaca
Copy link
Collaborator

Running test_issue_335_identify_UTC fails on my machine. Seems to be a timezone issue, since the diff shows that the dates are an hour apart. Any idea why that is?

Full testlog

@jacadzaca
Copy link
Collaborator Author

I think the issue is in line 506, since astimezone actually converts the given datetime to the timezone

If I change line line 505 to dt = datetime.datetime(2021, 11, 17, 15, 9, 15, tzinfo=zone) and line 506 to myevent.add('dtstart', dt) the tests pass, so it must be it

@jacadzaca jacadzaca linked a pull request Oct 7, 2022 that will close this issue
@niccokunzmann niccokunzmann reopened this Oct 7, 2022
@niccokunzmann
Copy link
Member

Hm. Is this changed in the tests in the master branch? I would close it then. The test code might be wrong.

@niccokunzmann
Copy link
Member

Ah. OK. The app I am using does not show the link to the merged PR. Alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants