Ignore invalid byte sequences #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a line of code has an invalid byte sequence in UTF-8, count it as a relevant line rather than crashing. Useful for projects that use `track_files "**/*.rb"` and have the builder gem in a subdir such as vendor. Builder has a line of code with an invalid UTF-8 byte sequence.
The previous implementation made the `classify` method too long for Rubocop. It also was ignoring invalid byte sequences in only one of the two places where we loop through the lines to look for :nocov:.
|
Not sure why Cucumber is failing in Ruby 1.9.3. "It works on my machine." |
|
That's the flaky I tried to fix and obviously failed... sorry :| |
PragTob
approved these changes
Mar 10, 2018
This was referenced Mar 15, 2018
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement on #664, which fixes SimpleCov so it won't crash when it encounters an invalid byte sequence in UTF-8.
This version is better in these ways:
classifymethod is still short enough to make Rubocop happy.:nocov::SimpleCov::LinesClassifier#classifyandSimpleCov::SourceFile.process_skipped_lines.Like #664, this fixes a regression that was introduced in v0.15.0 when
add_not_loaded_fileswas changed to callLinesClassifier#classify, which runs a RegExp on each line--and raises ArgumentError if the line had an invalid byte sequence.