-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure the license file gets included with the gem #672
Conversation
I didn't update the changelog because I wasn't sure what you'd want it to look like, but we'd love if this went out as 0.16.1. |
In Simplecov 0.16 vthey accidently excluded the MIT-LICENSE file from their gem which is causing failures in Jenkins for us in Chef. The PR to fix that is simplecov-ruby/simplecov#672, but until that gets merged and released we'll need an override. Signed-off-by: Tim Smith <tsmith@chef.io>
Sorry that happened! I think renaming the file to |
When the list of files to include was pruned down the LICENSE file was accidently pruned as well. This causes issues for projects that do strict license validation on depdendencies. Rename MIT-LICENSE to LICENSE so it gets bundled. Signed-off-by: Tim Smith <tsmith@chef.io>
@PragTob Updated to use LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
@tas50 and released as 0.16.1 |
When the list of files to include was pruned down the LICENSE file was
accidently pruned as well. This causes issues for projects that do
strict license validation on depdendencies.
Signed-off-by: Tim Smith tsmith@chef.io