Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the license file gets included with the gem #672

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Make sure the license file gets included with the gem #672

merged 1 commit into from
Mar 16, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Mar 15, 2018

When the list of files to include was pruned down the LICENSE file was
accidently pruned as well. This causes issues for projects that do
strict license validation on depdendencies.

Signed-off-by: Tim Smith tsmith@chef.io

@tas50
Copy link
Contributor Author

tas50 commented Mar 15, 2018

I didn't update the changelog because I wasn't sure what you'd want it to look like, but we'd love if this went out as 0.16.1.

tas50 added a commit to chef/license_scout that referenced this pull request Mar 15, 2018
In Simplecov 0.16 vthey accidently excluded the MIT-LICENSE file from
their gem which is causing failures in Jenkins for us in Chef. The PR to
fix that is simplecov-ruby/simplecov#672, but until
that gets merged and released we'll need an override.

Signed-off-by: Tim Smith <tsmith@chef.io>
@PragTob
Copy link
Collaborator

PragTob commented Mar 15, 2018

Sorry that happened!

I think renaming the file to LICENSE is more in line with community standards so that'd be my preferred change :)

When the list of files to include was pruned down the LICENSE file was
accidently pruned as well. This causes issues for projects that do
strict license validation on depdendencies. Rename MIT-LICENSE to
LICENSE so it gets bundled.

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50
Copy link
Contributor Author

tas50 commented Mar 15, 2018

@PragTob Updated to use LICENSE

Copy link
Collaborator

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

@PragTob PragTob merged commit 541f9ad into simplecov-ruby:master Mar 16, 2018
@PragTob
Copy link
Collaborator

PragTob commented Mar 16, 2018

@tas50 and released as 0.16.1

This was referenced Mar 16, 2018
This was referenced Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants