Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap failed while Waiting for Alice to lock Monero #688

Closed
MONT3M opened this issue Aug 26, 2021 · 7 comments · Fixed by #705
Closed

Swap failed while Waiting for Alice to lock Monero #688

MONT3M opened this issue Aug 26, 2021 · 7 comments · Fixed by #705
Labels
bug Something isn't working loss-of-funds Critical bug which can result in loss of funds

Comments

@MONT3M
Copy link

MONT3M commented Aug 26, 2021

Hi All,

I initiated a swap for 0.03 BTC (with the funds already in the internal wallet of the swap tool from a previously cancelled swap) and it failed as shown in the code at the bottom of this post.

The terminal was stuck on "Waiting for Alice to lock Monero" for a few hours before I went to sleep. Upon waking in the morning, I saw that the swap had failed/been cancelled as "Alice took too long to lock Monero." The ASB had punished me and took the 0.03 BTC sometime during the night as well. Afaik there was not break in my internet connection during this time.

Fortunately, I was contacted by the ASB operator that I initiated the swap with, and they were kind enough to let me know that there was no malicious intent behind the automatic punish and would like to see me get the XMR funds.

However they are also at a loss as to how I can recover my XMR funds as this situation has not happened to them before. According to them, the XMR are locked in the swap tool and need to be somehow be manually released to my XMR wallet. Would this manual release be accomplished from the trader or ASB side? Thank you for any help you can provide to either of us.

Terminal:

`XXXX@XXXX:~/Downloads$ ./swap buy-xmr --receive-address 4A8T1raSjhZf4WFAa3fBSxSLCF4PKk1ZEAXB28EcP7Z7QTdz8WYPLz3Ak2TF1bqBgMgCF8zZZpFDn8sFnVn6YpxoNkgXTA4 --change-address bc1qe43v6xas2uf3j7wq97w7jkckkk98hvlhs00u4r --seller /dnsaddr/commitcri.me/p2p/12D3KooWNT2FCb52QmQS1E4zGzaGdAkGWMUcBJuqTUTrkW3drvuf
Connected to Alice at /dnsaddr/commitcri.me/p2p/12D3KooWNT2FCb52QmQS1E4zGzaGdAkGWMUcBJuqTUTrkW3drvuf
Received quote price=0.00668673 BTC minimum_amount=0.00010000 BTC maximum_amount=0.03000000 BTC
Starting new swap amount=0.02999741 BTC fees=0.00000259 BTC swap_id=19b5438a-44ab-4fb8-9525-932e6d41f6dc
Estimated fee of 289.3440 is smaller than the min relay fee, defaulting to min relay fee 1000
Estimated fee of 314.6880 is smaller than the min relay fee, defaulting to min relay fee 1000
Published Bitcoin transaction txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac kind=lock
Waiting for Alice to lock Monero
Failed to get status of script: Failed to subscribe to header notifications: Made one or multiple attempts, all errored:
- CloseNotify alert received
txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac
Alice took too long to lock Monero, cancelling the swap
Error: Failed to complete swap

Caused by:
0: Failed to broadcast Bitcoin cancel transaction 50e4ea7e3b3d27a761f1be47cb207f958d2e4e10b36f694cd9c6629d239cd14e
1: Electrum(Protocol(String("sendrawtransaction RPC error: {\"code\":-26,\"message\":\"non-BIP68-final\"}")))`
@kareldonk

This comment has been minimized.

@thomaseizinger
Copy link
Contributor

Thanks for the report. At the moment, there isn't any functionality for a cooperative release of funds. It is an interesting idea, so I am going to open a separate issue for it!

As for the other issue, I am not exactly sure what is going wrong. For some reason, we seem to try to broadcast to early, which is something we actually guard against ...
There should be debug logs within your data directory. On Linux, that should be ~/.local/share/xmr-btc-swap.

Can you share those debug logs?
If you don't want to post them publicly, you can also share them on Matrix: @thomaseizinger:matrix.org.

@MONT3M
Copy link
Author

MONT3M commented Aug 26, 2021

Hi @thomaseizinger, thanks for the response, and setting up the issue #693

I am surprised that there is no current way for Bob to retrieve the locked XMR after Alice has punished and retrieved the BTC. May I ask why this is not standard to the protocol? Correct me if I am wrong, but those XMR are essentially burnt and will sit in the swap tool address for the rest of time?

And in a future where a manual release may be possible, what if Alice doesn't contact Bob or want to cooperatively release the locked XMR funds? Is Bob doomed to lose the BTC after the ASB automatically punishes after the 72 block timeframe?

I realize we should probably continue this conversation on the issue #693 you created, as the above may be off topic. And yes, I will post my debug logs as soon as have access to the pc I was running the swap tool on.
Thank you for working on this, I'd hate to see this situation happen to any other swap tool users.

And @kareldonk, as much I do appreciate you sympathizing with me and championing my issue here, I'd also really appreciate your civility in working with the devs so we can all come to a solution, or change to the protocol, that works for everyone.

@MONT3M
Copy link
Author

MONT3M commented Aug 27, 2021

@thomaseizinger, Here is the .log text for the Swap ID that went wrong. Please let me know if you need more info:

Aug 23 18:49:47.283 DEBUG Opening database at /home/XXXX/.local/share/xmr-btc-swap/cli/mainnet/database
Aug 23 18:49:47.329 DEBUG Reading in seed from /home/XXXX/.local/share/xmr-btc-swap/cli/mainnet/seed.pem
Aug 23 18:49:48.770 DEBUG Starting monero-wallet-rpc port=40295
Aug 23 18:49:52.384 DEBUG Opened Monero wallet monero_wallet_name=swap-tool-blockchain-monitoring-wallet
Aug 23 18:50:04.692 DEBUG Network layer initialized peer_id=12D3KooWHMbQaDER61iYyuL7mAzVeVScYgJKwWZe3XqNggFiGoc9
Aug 23 18:50:04.692 DEBUG Requesting quote
Aug 23 18:50:04.970 INFO Connected to Alice at /dnsaddr/commitcri.me/p2p/12D3KooWNT2FCb52QmQS1E4zGzaGdAkGWMUcBJuqTUTrkW3drvuf
Aug 23 18:50:05.032 INFO Received quote price=0.00668673 BTC minimum_amount=0.00010000 BTC maximum_amount=0.03000000 BTC
Aug 23 18:50:05.237 INFO Starting new swap amount=0.02999741 BTC fees=0.00000259 BTC swap_id=19b5438a-44ab-4fb8-9525-932e6d41f6dc
Aug 23 18:50:05.432 DEBUG Estimated fee for transaction weight=548 fee_rate=2.112 sats_per_vbyte=289.3440
Aug 23 18:50:05.432 WARN Estimated fee of 289.3440 is smaller than the min relay fee, defaulting to min relay fee 1000
Aug 23 18:50:05.626 DEBUG Estimated fee for transaction weight=596 fee_rate=2.112 sats_per_vbyte=314.6880
Aug 23 18:50:05.626 WARN Estimated fee of 314.6880 is smaller than the min relay fee, defaulting to min relay fee 1000
Aug 23 18:50:08.326 INFO Published Bitcoin transaction txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac kind=lock
Aug 23 18:50:08.328 INFO Waiting for Alice to lock Monero
Aug 23 18:50:13.194 DEBUG Found relevant Bitcoin transaction txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac status=unseen
Aug 23 18:50:53.404 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=in mempool old_status=unseen
Aug 23 18:59:11.766 DEBUG Got notification for new block block_height=697305
Aug 23 18:59:11.868 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 1 blocks old_status=in mempool
Aug 23 19:04:22.468 DEBUG Got notification for new block block_height=697306
Aug 23 19:04:22.566 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 2 blocks old_status=confirmed with 1 blocks
Aug 23 19:05:22.674 DEBUG Got notification for new block block_height=697307
Aug 23 19:05:22.768 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 3 blocks old_status=confirmed with 2 blocks
Aug 23 19:07:25.590 DEBUG Got notification for new block block_height=697308
Aug 23 19:07:25.697 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 4 blocks old_status=confirmed with 3 blocks
Aug 23 19:11:33.757 DEBUG Got notification for new block block_height=697309
Aug 23 19:11:33.856 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 5 blocks old_status=confirmed with 4 blocks
Aug 23 19:20:55.131 DEBUG Got notification for new block block_height=697310
Aug 23 19:20:55.231 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 6 blocks old_status=confirmed with 5 blocks
Aug 23 19:22:57.938 DEBUG Got notification for new block block_height=697311
Aug 23 19:22:58.035 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 7 blocks old_status=confirmed with 6 blocks
Aug 23 19:33:22.305 DEBUG Got notification for new block block_height=697312
Aug 23 19:33:22.410 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 8 blocks old_status=confirmed with 7 blocks
Aug 23 19:35:25.113 DEBUG Got notification for new block block_height=697313
Aug 23 19:35:25.208 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 9 blocks old_status=confirmed with 8 blocks
Aug 23 19:37:28.086 DEBUG Got notification for new block block_height=697314
Aug 23 19:37:28.184 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 10 blocks old_status=confirmed with 9 blocks
Aug 23 19:45:48.985 DEBUG Got notification for new block block_height=697315
Aug 23 19:45:49.084 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 11 blocks old_status=confirmed with 10 blocks
Aug 23 19:51:02.181 DEBUG Got notification for new block block_height=697316
Aug 23 19:51:02.271 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 12 blocks old_status=confirmed with 11 blocks
Aug 23 20:03:31.715 DEBUG Got notification for new block block_height=697317
Aug 23 20:03:31.851 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 13 blocks old_status=confirmed with 12 blocks
Aug 23 20:33:46.900 DEBUG Got notification for new block block_height=697318
Aug 23 20:33:46.997 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 14 blocks old_status=confirmed with 13 blocks
Aug 23 20:40:00.743 DEBUG Got notification for new block block_height=697319
Aug 23 20:40:00.842 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 15 blocks old_status=confirmed with 14 blocks
Aug 23 20:45:11.399 DEBUG Got notification for new block block_height=697320
Aug 23 20:45:11.495 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 16 blocks old_status=confirmed with 15 blocks
Aug 23 21:04:58.891 DEBUG Got notification for new block block_height=697321
Aug 23 21:04:58.989 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 17 blocks old_status=confirmed with 16 blocks
Aug 23 21:05:59.106 DEBUG Got notification for new block block_height=697322
Aug 23 21:05:59.206 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 18 blocks old_status=confirmed with 17 blocks
Aug 23 21:08:01.986 DEBUG Got notification for new block block_height=697323
Aug 23 21:08:02.084 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 19 blocks old_status=confirmed with 18 blocks
Aug 23 21:12:10.041 DEBUG Got notification for new block block_height=697324
Aug 23 21:12:10.145 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 20 blocks old_status=confirmed with 19 blocks
Aug 23 21:39:14.897 DEBUG Got notification for new block block_height=697325
Aug 23 21:39:14.997 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 21 blocks old_status=confirmed with 20 blocks
Aug 23 21:46:30.613 DEBUG Got notification for new block block_height=697326
Aug 23 21:46:30.710 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 22 blocks old_status=confirmed with 21 blocks
Aug 23 21:50:38.543 DEBUG Got notification for new block block_height=697327
Aug 23 21:50:38.641 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 23 blocks old_status=confirmed with 22 blocks
Aug 23 21:59:59.526 DEBUG Got notification for new block block_height=697328
Aug 23 21:59:59.621 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 24 blocks old_status=confirmed with 23 blocks
Aug 23 22:08:17.946 DEBUG Got notification for new block block_height=697329
Aug 23 22:08:18.044 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 25 blocks old_status=confirmed with 24 blocks
Aug 23 22:25:59.827 DEBUG Got notification for new block block_height=697330
Aug 23 22:25:59.922 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 26 blocks old_status=confirmed with 25 blocks
Aug 23 22:29:05.557 DEBUG Got notification for new block block_height=697331
Aug 23 22:29:05.662 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 27 blocks old_status=confirmed with 26 blocks
Aug 23 22:50:57.881 DEBUG Got notification for new block block_height=697332
Aug 23 22:50:57.975 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 28 blocks old_status=confirmed with 27 blocks
Aug 23 22:57:11.568 DEBUG Got notification for new block block_height=697333
Aug 23 22:57:11.668 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 29 blocks old_status=confirmed with 28 blocks
Aug 23 23:00:17.373 DEBUG Got notification for new block block_height=697334
Aug 23 23:00:17.471 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 30 blocks old_status=confirmed with 29 blocks
Aug 23 23:08:31.705 DEBUG Got notification for new block block_height=697335
Aug 23 23:08:31.804 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 31 blocks old_status=confirmed with 30 blocks
Aug 23 23:10:34.559 DEBUG Got notification for new block block_height=697336
Aug 23 23:10:34.662 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 32 blocks old_status=confirmed with 31 blocks
Aug 23 23:13:40.024 DEBUG Got notification for new block block_height=697337
Aug 23 23:13:40.132 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 33 blocks old_status=confirmed with 32 blocks
Aug 23 23:16:45.525 DEBUG Got notification for new block block_height=697339
Aug 23 23:16:45.625 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 35 blocks old_status=confirmed with 33 blocks
Aug 23 23:26:08.351 DEBUG Got notification for new block block_height=697340
Aug 23 23:26:08.455 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 36 blocks old_status=confirmed with 35 blocks
Aug 23 23:40:43.022 DEBUG Got notification for new block block_height=697341
Aug 23 23:40:43.121 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 37 blocks old_status=confirmed with 36 blocks
Aug 23 23:41:43.236 DEBUG Got notification for new block block_height=697342
Aug 23 23:41:43.336 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 38 blocks old_status=confirmed with 37 blocks
Aug 23 23:48:59.052 DEBUG Got notification for new block block_height=697343
Aug 23 23:48:59.158 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 39 blocks old_status=confirmed with 38 blocks
Aug 24 00:07:43.247 DEBUG Got notification for new block block_height=697344
Aug 24 00:07:43.351 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 40 blocks old_status=confirmed with 39 blocks
Aug 24 00:29:35.221 DEBUG Got notification for new block block_height=697345
Aug 24 00:29:35.323 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 41 blocks old_status=confirmed with 40 blocks
Aug 24 00:45:11.998 DEBUG Got notification for new block block_height=697346
Aug 24 00:45:12.096 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 42 blocks old_status=confirmed with 41 blocks
Aug 24 00:57:39.470 DEBUG Got notification for new block block_height=697347
Aug 24 00:57:39.578 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 43 blocks old_status=confirmed with 42 blocks
Aug 24 00:59:42.274 DEBUG Got notification for new block block_height=697349
Aug 24 00:59:42.377 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 45 blocks old_status=confirmed with 43 blocks
Aug 24 01:09:04.598 DEBUG Got notification for new block block_height=697350
Aug 24 01:09:04.693 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 46 blocks old_status=confirmed with 45 blocks
Aug 24 01:15:17.648 DEBUG Got notification for new block block_height=697351
Aug 24 01:15:17.743 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 47 blocks old_status=confirmed with 46 blocks
Aug 24 01:41:21.927 DEBUG Got notification for new block block_height=697352
Aug 24 01:41:22.044 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 48 blocks old_status=confirmed with 47 blocks
Aug 24 01:42:22.153 DEBUG Got notification for new block block_height=697353
Aug 24 01:42:22.248 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 49 blocks old_status=confirmed with 48 blocks
Aug 24 01:43:22.356 DEBUG Got notification for new block block_height=697354
Aug 24 01:43:22.448 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 50 blocks old_status=confirmed with 49 blocks
Aug 24 02:14:39.116 DEBUG Got notification for new block block_height=697355
Aug 24 02:14:39.220 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 51 blocks old_status=confirmed with 50 blocks
Aug 24 02:25:02.722 DEBUG Got notification for new block block_height=697356
Aug 24 02:25:02.820 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 52 blocks old_status=confirmed with 51 blocks
Aug 24 02:30:14.521 DEBUG Got notification for new block block_height=697357
Aug 24 02:30:14.622 DEBUG Bitcoin transaction status changed txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac new_status=confirmed with 53 blocks old_status=confirmed with 52 blocks
Aug 24 03:02:40.423 WARN Failed to get status of script: Failed to subscribe to header notifications: Made one or multiple attempts, all errored:
- CloseNotify alert received
txid=cc785b2ab2f1d546500c9d4040d5e634abfd6ee18188e12ffbac264111e79dac
Aug 24 03:02:40.426 INFO Alice took too long to lock Monero, cancelling the swap
(END)

@rishflab rishflab added bug Something isn't working loss-of-funds Critical bug which can result in loss of funds labels Aug 27, 2021
@thomaseizinger
Copy link
Contributor

And in a future where a manual release may be possible, what if Alice doesn't contact Bob or want to cooperatively release the locked XMR funds? Is Bob doomed to lose the BTC after the ASB automatically punishes after the 72 block timeframe?

Yes, this is due to Monero not having any timelocks. From the protocol perspective, Bob (the user) may be malicious and never claim the XMR. Without claiming the XMR, Alice can never retrieve the BTC.

As a result, she is allowed to claim the BTC funds after another 72 block time window.

Swap protocols are time-sensitive. As long as both parties are online and act within a certain time frame, no funds are lost. If one party just disappears either willingly or unwillingly, certain spending paths must become possible otherwise the incentives in the protocol don't work out. That is unfortunately the nature of non-custodial and trustless protocols like these.

will sit in the swap tool address for the rest of time?

They don't sit in the tool. They sit in a multi-sig on the chain and can only be claimed through collaboration by both parties. Normal execution of the swap is essentially this collaboration.

I am surprised that there is no current way for Bob to retrieve the locked XMR after Alice has punished and retrieved the BTC. May I ask why this is not standard to the protocol?

It may be possible but has to be thought through properly, I've opened a discussion here: #713

@rishflab rishflab linked a pull request Sep 2, 2021 that will close this issue
@rishflab
Copy link
Member

rishflab commented Sep 6, 2021

Addressed in linked PR

@rishflab rishflab closed this as completed Sep 6, 2021
@asheroto
Copy link

asheroto commented Dec 1, 2021

I'm having this bug as well. What is a ballpark timeframe for Alice to lock Monero? 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working loss-of-funds Critical bug which can result in loss of funds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants