Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing better with Poison dependency #91

Closed
olafura opened this issue Dec 2, 2017 · 1 comment
Closed

Dealing better with Poison dependency #91

olafura opened this issue Dec 2, 2017 · 1 comment

Comments

@olafura
Copy link
Contributor

olafura commented Dec 2, 2017

See how phoenix is doing it:
https://github.com/phoenixframework/phoenix/blob/master/mix.exs#L63

Since a lot of libraries use this dependency you need to be careful with not breaking them if you don't need any never functionality.

@slashdotdash
Copy link
Member

@olafura Thanks for the hint on dependency references, I’m happy to make the change.

@slashdotdash slashdotdash changed the title Dealing better with Poison dependancy Dealing better with Poison dependency Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants