Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include params in cache key #76

Open
markus-mw opened this issue Apr 7, 2021 · 1 comment
Open

Include params in cache key #76

markus-mw opened this issue Apr 7, 2021 · 1 comment

Comments

@markus-mw
Copy link

The cacheKey in getCategories method is lacking the params array. There should be added something like this:

$cacheKey = static::CATEGORIES_NAME . '-' . $locale . md5(serialize($params));

$cacheKey = static::CATEGORIES_NAME . '-' . $locale;

@markus-mw markus-mw changed the title Include params in Cache key Include params in cache key Apr 7, 2021
@jenschude
Copy link
Contributor

Hi,

we are atm not actively working on this package. In case you need the functionality soon you could fork the repository or copy/extend the specific class according to your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants