refactor(components): lazy load custom view selector in modular tab components #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 68d5b82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
emmenko
commented
Jan 10, 2025
Comment on lines
+176
to
+178
| const { currentCustomViewLocatorCode } = useCustomViewLocatorSelector( | ||
| props.customViewLocatorCodes | ||
| ); |
There was a problem hiding this comment.
We are now using the hook here to match the router location
emmenko
commented
Jan 10, 2025
Comment on lines
+7
to
+12
| if (typeof window !== 'undefined' && typeof window.app !== 'undefined') { | ||
| return import( | ||
| './custom-views-selector' /* webpackChunkName: "custom-views-selector" */ | ||
| ); | ||
| } | ||
| return Promise.resolve({ default: () => null }); |
There was a problem hiding this comment.
Here we evaluate if the component should be lazy loaded or not, by relying on window.app being defined
emmenko
commented
Jan 10, 2025
Comment on lines
+3
to
+6
| export type TCustomViewLocatorCodeLocationDescriptor = { | ||
| pathname?: string; | ||
| search?: string; | ||
| }; |
There was a problem hiding this comment.
Instead of using the type LocationDescriptor from history, we define our own similar type.
emmenko
force-pushed
the
nm-tab-page-decouple-custom-view-selector
branch
from
cd2f282 to
68d5b82
Compare
tylermorrisford
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goals:
window.appis defined)