Support for dependent packages in Mercurial #1397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The ability to refer to a dependency on a git commit is useful, and I'd quite like to add support for the same thing for Mercurial repositories.
Firstly, would that be useful?
Secondly, I think all I'd have to do would be to add a new constructor to
Stack.Types.Config.PackageLocation
, implementToJSON
andFromJSON
, and add a new case toStack.Config.resolvePackageLocation
that would look very similar to the git one except would runhg clone
and thenhg update -C
instead ofgit clone
andgit reset --hard
respectively. I've not actually tried it so perhaps there's more, but it'd be useful to know I'm on the right lines.Thirdly, the cases for
PLHttpTarball
andPLGit
are already rather similar and I'd feel bad adding a third case just like them. Would it be ok to extract the common code into one place too?Cheers,
David