Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack benchmark output is not visible in terminal #1908

Open
wdanilo opened this issue Mar 13, 2016 · 4 comments
Open

Stack benchmark output is not visible in terminal #1908

wdanilo opened this issue Mar 13, 2016 · 4 comments

Comments

@wdanilo
Copy link

wdanilo commented Mar 13, 2016

Hello!
I've configured benchmarks in my cabal config and when I'm running stack bench, stacks builds all necessary components (including the ones needed by benchmarks) and the last line of the build process is <pkg name>: benchmarks.

I can see benchmarks output among logs and if some benchmarks fail I can see it in the terminal too. But if everything succeeds, the logs are just hidden in the cmd. Is there a way to reveal them?

@wdanilo wdanilo changed the title Stack bench doesnt work when used with options --work-dir and --stack-yaml Stack bench doesnt run any benchmarks Mar 13, 2016
@wdanilo wdanilo changed the title Stack bench doesnt run any benchmarks Stack benchmark output is not visible in terminal Mar 13, 2016
@mgsloan
Copy link
Contributor

mgsloan commented Mar 15, 2016

If you run a single benchmark, do you get its output? It's using the same logic that's used to determine if a build log is outputted - if it's a target and the last thing executing, IIRC. I agree that this should be improved - see this issue: #426

stack bench is a bit of a rougher part of stack. I've just realized we should probably execute them sequentially: #1913

This means that they wouldn't run in parallel with other tasks, and so it's reasonable to send their output directly to the user.

@mgsloan mgsloan added this to the P2: Should milestone Mar 15, 2016
@rrnewton
Copy link
Contributor

So it sounds like once #1913 is fixed, this will automatically be fixed as a consequence of the existing print-serial-output policy?

@mgsloan
Copy link
Contributor

mgsloan commented Apr 18, 2016

Yes, hopefully so. It may require some tweaks to that logic, though, remains to be seen. Good thing to consider when working on #1913!

@mgsloan
Copy link
Contributor

mgsloan commented Apr 29, 2016

Actually, I was simply wrong about #1913. So, we are actually executing tests and benchmarks sequentially. In that case, it makes sense to me to output it to the terminal by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants