Skip to content

Commit 6e23aff

Browse files
committed
style(typing): fix MyPy lints
1 parent 8634eff commit 6e23aff

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

commitizen/bump.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,7 @@ def normalize_tag(
117117
| ver1.0.0.a0 | 1.0.0a0 |
118118
"""
119119
scheme = scheme or DEFAULT_SCHEME
120-
121-
if isinstance(version, str):
122-
version = scheme(version)
120+
version = scheme(version) if isinstance(version, str) else version
123121

124122
if not tag_format:
125123
return str(version)

commitizen/changelog.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import re
3131
from collections import OrderedDict, defaultdict
3232
from datetime import date
33-
from typing import TYPE_CHECKING, Callable, Dict, Iterable, List, Optional, Tuple
33+
from typing import TYPE_CHECKING, Callable, Dict, Iterable, List, Optional, Tuple, cast
3434

3535
from jinja2 import Environment, PackageLoader
3636
from packaging.version import InvalidVersion
@@ -182,7 +182,7 @@ def parse_version_from_markdown(value: str, scheme: Scheme = Pep440) -> Optional
182182
m = scheme.parser.search(value)
183183
if not m:
184184
return None
185-
return m.groupdict().get("version")
185+
return cast(str, m.groupdict().get("version"))
186186

187187

188188
def parse_title_type_of_line(value: str) -> Optional[str]:

commitizen/schemes.py

+5-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from __future__ import annotations
22
from itertools import zip_longest
33
import re
4+
import sys
45

56
from typing import TYPE_CHECKING, ClassVar, Optional, Type
67

@@ -10,15 +11,13 @@
1011

1112
if TYPE_CHECKING:
1213
# TypeAlias is Python 3.10+ but backported in typing-extensions
13-
try:
14+
if sys.version_info >= (3, 10):
1415
from typing import TypeAlias
15-
except ImportError:
16+
else:
1617
from typing_extensions import TypeAlias
1718

1819
# Self is Python 3.11+ but backported in typing-extensions
19-
try:
20-
from typing import Self # type: ignore
21-
except ImportError:
20+
if sys.version_info < (3, 11):
2221
from typing_extensions import Self
2322

2423

@@ -105,7 +104,7 @@ def bump(
105104
prerelease_offset: int = 0,
106105
devrelease: Optional[int] = None,
107106
is_local_version: bool = False,
108-
) -> Self:
107+
) -> Self: # type: ignore
109108
"""Based on the given increment a proper semver will be generated.
110109
111110
For now the rules and versioning scheme is based on

0 commit comments

Comments
 (0)