Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select change type with arrow keys #10

Closed
BarryThePenguin opened this issue Sep 10, 2015 · 21 comments
Closed

Can't select change type with arrow keys #10

BarryThePenguin opened this issue Sep 10, 2015 · 21 comments

Comments

@BarryThePenguin
Copy link

Just a heads up I am experiencing the following on WIndows 8.1 SBoudrias/Inquirer.js#266

node -v 4.0.0

cc @kentcdodds

@kentcdodds
Copy link
Member

Hmmm. That's annoying :-( I guess you'll just have to hand-craft your commits until that bug gets fixed...

@BarryThePenguin
Copy link
Author

I followed the rabbit hole and found nodejs/node#2996

@jimthedev
Copy link
Member

Interesting. Thanks for finding that. Is this something we should add to docs until it gets resolved?

@kentcdodds
Copy link
Member

Seems like a good idea to me. I'm thinking about adding it to my contributing docs... Even better: detect the node version and os and give a warning if this could be a problem.

@jimthedev jimthedev added this to the Unscheduled milestone Oct 21, 2015
@jimthedev
Copy link
Member

Quick update. Looks like the node issue is still open and they're trying to figure out a fix that doesn't introduce a regression. Until then, we wait. :)

@jimthedev
Copy link
Member

Update: It looks like the change that started causing this issue has been reverted so I'd imagine it is available in nightlies: nodejs/node@af46112

But I'm not sure when it will get released and perhaps more importantly when it will get back ported to Node 4 LTS.

@jimthedev
Copy link
Member

Quick update: This will be released in the next Node.js versions on both the 4.x and 5.x branches. I'm going to close the issue for now since it is merged and out of the control of this repo.

More info:
eslint/eslint#3880

@ocombe
Copy link

ocombe commented Nov 28, 2015

I just had the problem on windows, it still doesn't work with the last 4.x version (4.2.2), but it works with the last 5.x version (5.1.0), so that's all good :)

@jimthedev
Copy link
Member

Thanks for the confirmation @ocombe. I know there are some security patches being worked into older versions so perhaps it is taking a bit longer to get this in to those. At any rate, it is good to know it is fixed in 5.x!!!

@clearbug
Copy link

I also met this .How do you solve this problem? @BarryThePenguin

@egoroof
Copy link

egoroof commented Feb 29, 2016

@clearbug see nodejs/node#5384. Now it's a new problem.

@jimthedev jimthedev reopened this Apr 28, 2016
@jimthedev
Copy link
Member

I re-opened this since as @egoroof stated, this continues to be a node or windows issue. Latest update from nodejs/node#5384 is that it might be an issue with windows itself. Basically it is tricky to fix because it presents as a race condition.

@simonwjackson
Copy link

Commitizen is essential to my dev workflow, so I made a quick hack so I could just type out the feature (rather than use arrow keys).

This gets the job done, but i hope the nodejs guys get this sorted out.

simonwjackson/cz-conventional-changelog@c408892e6fda003f70fdcadcd17c277a75b7d82c

@BarryThePenguin
Copy link
Author

BarryThePenguin commented May 16, 2016

Looks like there's another potential fix coming through libuv/libuv#852, nodejs/node#6796

@Mouvedia
Copy link

Both are closed.

@meszaros-lajos-gyorgy
Copy link

I experience the same on Windows 7 using the git bash from the latest Git install (mintty 2.7.3 x86_64-pc-msys). It works fine in windows cmd.

@wcalebgray
Copy link

Seeing this on Windows 10 as well (mintty 2.7.7 x86_64-pc-msys)

@xetra11
Copy link

xetra11 commented Sep 1, 2017

Having this issue, too. CMD and GIT BASH both deny the arrow movement

@yanfeipeng
Copy link

window cmd can work, but git bash mintty not
image

@sschmidTU
Copy link

sschmidTU commented Jul 9, 2018

Workaround
In my Git Bash keypresses are actually executed invisibly, they just don't cause a rendering refresh. So e.g. for a refactor, after git cz i press down arrow 4 times and hit enter, and it shows refactor as type of change.

(Windows 10 Version 1803, mintty 2.8.5, git bash 2.8.0 - try installing the latest version of git bash)

Found this after a lot of research subtly hidden here, comment from March 3 2018:
terkelg/prompts#36

@mrseanryan
Copy link

mrseanryan commented Nov 29, 2018

Workaround - use yarn instead of npm

in case it helps: - I have similar issue
on my Windows 10 Pro box, git bash terminal

  • node 8.11.3
  • commitizen 3.0.5

If I use:

npm run commit

then the arrow keys do not work.

BUT if I instead use yarn:

yarn run commit

then the arrow keys DO work, and I can successfully select a change type.

related: previously, when arrows were broken, I was typing in 'docs' or 'refactor'

  • it could be nice to also allow that instead of the arrows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests