Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No license in pom file #347

Closed
ganadist opened this issue Oct 14, 2024 · 3 comments · Fixed by #351
Closed

No license in pom file #347

ganadist opened this issue Oct 14, 2024 · 3 comments · Fixed by #351
Labels

Comments

@ganadist
Copy link

I'm using Google OSS License plugin to show libraries' licenses to end users.

And after add commonmark-java dependency, I found license activity don't show license of commommark-java

I found there is license declaration on root (commonmark-parent) project.
https://github.com/commonmark/commonmark-java/blob/main/pom.xml#L264-L270

But, main java project(commonmark-parent) don't have license declaration.
https://github.com/commonmark/commonmark-java/blob/main/commonmark/pom.xml

And there is no license declaration on Maven POM File.
https://central.sonatype.com/artifact/org.commonmark/commonmark

Could you add license declaration on POM file of commonmark-java?

@ganadist ganadist added the bug label Oct 14, 2024
@ganadist
Copy link
Author

I found https://maven.apache.org/pom.html#inheritance and it looks Google OSS License plugin does not implement inheritance case from parent.
I'll submit issue on https://github.com/google/play-services-plugins

@robinst
Copy link
Collaborator

robinst commented Oct 21, 2024

Agreed that this is a bug in play-services-plugins, but I'm happy to add it to at least the core pom to work around it, see:

@ganadist
Copy link
Author

Confirmed that license appeared on OSS License activity with commonmark-java 0.24.0
Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants