Skip to content

Dingus shows incorrect sourcepos value for paragraphs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Knagis opened this issue Jan 29, 2015 · 3 comments
Closed

Dingus shows incorrect sourcepos value for paragraphs #4

Knagis opened this issue Jan 29, 2015 · 3 comments

Comments

@Knagis
Copy link

Knagis commented Jan 29, 2015

http://spec.commonmark.org/dingus.html?text=123

At first the value seems correct (<paragraph data-sourcepos="1:1-1:3">) but as soon as you start typing/clicking in the editor, it goes off: <paragraph data-sourcepos="19:1-1:12">

Probably because this.lineNumber is not reset.

@jgm
Copy link
Member

jgm commented Jan 29, 2015

I think this is a dup of #3. I'll update the live dingus.

@jgm
Copy link
Member

jgm commented Jan 29, 2015

Try it now, I've updated the code on the dingus.

@Knagis
Copy link
Author

Knagis commented Jan 29, 2015

Yes, this has been fixed.

@Knagis Knagis closed this as completed Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants