Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phrasal search #18

Open
sylvinus opened this issue Feb 20, 2016 · 6 comments
Open

Phrasal search #18

sylvinus opened this issue Feb 20, 2016 · 6 comments

Comments

@sylvinus
Copy link
Contributor

Queries like "new york times" should search for the exact sequence of words.

Elasticsearch supports this, but it seems that if we want to mix phrase matches with regular matches we will have to do some preprocessing?

@wumpus
Copy link

wumpus commented Jul 12, 2016

Do you really mean "new york times" in quotes, or the query [new york times] with no quotes? (I use the contention to put query text in [] to avoid ambiguity... then quotes really mean quotes.)

@sylvinus
Copy link
Contributor Author

Right! I added the Markdown formatting but let's try to stick with [] for queries indeed! I meant ["new york times"] :)

@wumpus
Copy link

wumpus commented Jul 12, 2016

OK with the quotes, isn't it trivial to do the necessary query parsing?

The non-quotes case is also interesting, because it's much more common. But we can talk about that another time!

@sylvinus
Copy link
Contributor Author

You're right - this probably isn't a hard issue, I'll downgrade it :)

To make the issue clearer, we also need to support queries like ["new york times" 2016]

@sylvinus sylvinus added medium and removed hard labels Jul 12, 2016
@amirouche
Copy link

FWIW it's called phrasal search

@sylvinus sylvinus changed the title Phrase matching Phrasal search Oct 13, 2016
@sylvinus
Copy link
Contributor Author

Thanks @amirouche :) Want to have a swing at it ? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants