Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctkWrapPythonQt.py fails on Korean computers on source files starting with UTF-8 BOM #1214

Open
lassoan opened this issue Aug 15, 2024 · 0 comments
Open

ctkWrapPythonQt.py fails on Korean computers on source files starting with UTF-8 BOM #1214

lassoan opened this issue Aug 15, 2024 · 0 comments
Assignees
@jcfr

Comments

@lassoan
Copy link
Member

lassoan commented Aug 15, 2024

Some CTK source files start with UTF-8 BOM, which causes build failures on Korean computers (cp949 system code page) due to [ctkWrapPythonQt.py](

CTK/CMake/ctkWrapPythonQt.py

Line 93 in f01b620

content = f.read()
fails on computers) failing on files containing a BOM.

ctkWrapPythonQt.py should be made more robust to work well regardless of system code page.
@lassoan lassoan changed the title ctkWrapPythonQt.py fails on Korean computers on source files starting with URF-8 BOM ctkWrapPythonQt.py fails on Korean computers on source files starting with UTF-8 BOM Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfr jcfr

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcfr @lassoan