Amount of retries configurable #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shaharyar-shamshi
force-pushed
the
feat/error_429_retries
branch
2 times, most recently
from
57e4edf to
b4bb87b
Compare
|
@lullis if you can kindly review it |
shaharyar-shamshi
force-pushed
the
feat/error_429_retries
branch
2 times, most recently
from
2e5cf3b to
3d2f9ff
Compare
shaharyar-shamshi
changed the title
lullis
reviewed
Nov 17, 2022
lullis
reviewed
Nov 17, 2022
| @@ -20,6 +21,12 @@ class ShipBobClient(Session): | |||
|
|
|||
| ACCESS_TOKEN = os.getenv("SHIPBOB_ACCESS_TOKEN") | |||
|
|
|||
| MAX_RETRIES_AFTER_RATE_LIMIT: int = os.getenv("SHIPBOB_MAX_RETRIES_AFTER_RATE_LIMIT") | |||
There was a problem hiding this comment.
Instead of having a limit of amount of times to retry, wouldn't it be better/easier to track the amount of time since the last successful request?
There was a problem hiding this comment.
@lullis it is being handled this is maximum number of retries to perform and I am mainting the separate counter RETRIES_AFTER_RATE_LIMIT to count number of time since last successful request
|
@lullis if you can review this PR |
|
@lullis do let me if I need to change anything more |
shaharyar-shamshi
force-pushed
the
feat/error_429_retries
branch
from
59d6d01 to
0f75736
Compare
shaharyar-shamshi
force-pushed
the
feat/error_429_retries
branch
from
3af8b5b to
1d4e2ec
Compare
Signed-off-by: Shaharyar Shamshi <shaharyarshamshi@gmail.com>
shaharyar-shamshi
force-pushed
the
feat/error_429_retries
branch
from
1d4e2ec to
207d813
Compare
|
@lullis do I need to update anything |
lullis
reviewed
Mar 8, 2023
shaharyar-shamshi
force-pushed
the
feat/error_429_retries
branch
from
97e82ec to
f3aac5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7