-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User transactable attributes may halt progress if sources dictate times #62
Comments
A quick fix here a73c867 |
This should be addressed in f09ec28. I've added some simple unit tests to the domain module, but more are required to gain confidence. |
More tests added in 491554a. The logic seems correct (now, had to fix a bunch of edge cases...), and the interesting case is 491554a#diff-02e97a1fbd4aa8f2c9eac9bb8a89a414R57, which stalls everything as expected. Domain's now expose For domains with probed sources, As discussed, we should move away from checking anything in the server loop and simply always step a bunch, and |
Just ran into this.
0561422 introduced
advance_domain_to_source()
which enables sources to dictate times.Internally we use the domain probe to gather frontier information about all attributes in one domain.
This frontier information in turn is then used to advance() all kinds of things.
We probe source created as well as user created attributes.
Source attribute sessions are auto_flush as soon as the source downgrades its capability.
User created attribute sessions are not.
This leads to the problem that the frontier is stuck on the transaction of the user.
advance_source_to_domain()
is unable to advance based on the domains frontier information, as it is held back by the user created attribute.One solution is to simply not probe the user created and transactable attributes.
Transactions to the user attributes are given to its session at the correct current epoch.
One thing that arrises is that then user input is bound to source timestamps...
The text was updated successfully, but these errors were encountered: