Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaled problem and x0 solver initialisation #42

Open
timmeinhardt opened this issue Sep 1, 2017 · 2 comments
Open

Scaled problem and x0 solver initialisation #42

timmeinhardt opened this issue Sep 1, 2017 · 2 comments

Comments

@timmeinhardt
Copy link

Creating a Problem with scale=True causes a scaling of the prox functions with the operator norm Knorm. This usually works fine, but when a problem is solved with an x0 initialisation other than None (i.e. all zeros in x0) the scaling of the parameters and the input do not match. From my understanding the initialisation x0 has to be scaled as well. For example with:

x0 = x0.copy() * np.sqrt(Knorm)

In which case the operator norm has to be passed to the solve function. Without this scaling my results were considerably worse. This effect is of course only observable if Knorm != 1.0.

@SteveDiamond
Copy link
Contributor

This is a great point (as are #41 and #40). Would you mind compiling them all into a single pull request?

@timmeinhardt
Copy link
Author

I am happy to prepare a PR for the three issues, but are you sure that my fix of #40 is the best way of solving the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants