forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of rust-lang#133286 - jieyouxu:bug-ourselves, r=compiler…
…-errors Re-delay a resolve `bug` related to `Self`-ctor in patterns For the code pattern reported in <rust-lang#133272>, ```rs impl Foo { fn fun() { let S { ref Self } = todo!(); } } ``` <rust-lang#121208> converted this to a `span_bug` from a `span_delayed_bug` because this specific self-ctor code pattern lacked test coverage. It turns out this can be hit but we just lacked test coverage, so change it back to a `span_delayed_bug` and add a targeted test case. Follow-up to rust-lang#121208, cc `````@nnethercote````` (very good exercise to expose our test coverage gaps). Fixes rust-lang#133272.
- Loading branch information
Showing
3 changed files
with
39 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
//! Regression test for <https://github.com/rust-lang/rust/issues/133272>, where a `ref Self` ctor | ||
//! makes it possible to hit a `delayed_bug` that was converted into a `span_bug` in | ||
//! <https://github.com/rust-lang/rust/pull/121208>, and hitting this reveals that we did not have | ||
//! test coverage for this specific code pattern (heh) previously. | ||
//! | ||
//! # References | ||
//! | ||
//! - ICE bug report: <https://github.com/rust-lang/rust/issues/133272>. | ||
//! - Previous PR to change `delayed_bug` -> `span_bug`: | ||
//! <https://github.com/rust-lang/rust/pull/121208> | ||
#![crate_type = "lib"] | ||
|
||
struct Foo; | ||
|
||
impl Foo { | ||
fn fun() { | ||
let S { ref Self } = todo!(); | ||
//~^ ERROR expected identifier, found keyword `Self` | ||
//~| ERROR cannot find struct, variant or union type `S` in this scope | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
error: expected identifier, found keyword `Self` | ||
--> $DIR/self-ctor-133272.rs:17:21 | ||
| | ||
LL | let S { ref Self } = todo!(); | ||
| ^^^^ expected identifier, found keyword | ||
|
||
error[E0422]: cannot find struct, variant or union type `S` in this scope | ||
--> $DIR/self-ctor-133272.rs:17:13 | ||
| | ||
LL | let S { ref Self } = todo!(); | ||
| ^ not found in this scope | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0422`. |