Skip to content

Commit 4e716da

Browse files
mcbartonmcbarton
authored
Turn assertions off
1 parent c6f89c0 commit 4e716da

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

‎.github/workflows/emscripten.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ jobs:
175175
-DLLVM_EXTERNAL_CLING_SOURCE_DIR=../../cling \
176176
-DCMAKE_BUILD_TYPE=Release \
177177
-DLLVM_HOST_TRIPLE=wasm32-unknown-emscripten \
178-
-DLLVM_ENABLE_ASSERTIONS=ON \
178+
-DLLVM_ENABLE_ASSERTIONS=OFF \
179179
-DLLVM_TARGETS_TO_BUILD="${{ matrix.llvm_targets_to_build }}" \
180180
-DLLVM_ENABLE_LIBEDIT=OFF \
181181
-DLLVM_ENABLE_PROJECTS="${{ matrix.llvm_enable_projects }}" \
@@ -194,8 +194,8 @@ jobs:
194194
-DLLVM_ENABLE_LIBPFM=OFF \
195195
-DCLANG_BUILD_TOOLS=OFF \
196196
-DLLVM_NATIVE_TOOL_DIR=$NATIVE_DIR \
197-
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0" \
198-
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0" \
197+
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" \
198+
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" \
199199
-DLLVM_ENABLE_LTO=Full \
200200
../llvm
201201
emmake ninja clang cling lld gtest_main
@@ -209,7 +209,7 @@ jobs:
209209
cd build
210210
emcmake cmake -DCMAKE_BUILD_TYPE=Release \
211211
-DLLVM_HOST_TRIPLE=wasm32-unknown-emscripten \
212-
-DLLVM_ENABLE_ASSERTIONS=ON \
212+
-DLLVM_ENABLE_ASSERTIONS=OFF \
213213
-DLLVM_TARGETS_TO_BUILD="${{ matrix.llvm_targets_to_build }}" \
214214
-DLLVM_ENABLE_LIBEDIT=OFF \
215215
-DLLVM_ENABLE_PROJECTS="${{ matrix.llvm_enable_projects }}" \
@@ -228,8 +228,8 @@ jobs:
228228
-DCLANG_BUILD_TOOLS=OFF \
229229
-G Ninja \
230230
-DLLVM_NATIVE_TOOL_DIR=$NATIVE_DIR \
231-
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0" \
232-
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0" \
231+
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" \
232+
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" \
233233
-DLLVM_ENABLE_LTO=Full \
234234
../llvm
235235
emmake ninja libclang clangInterpreter clangStaticAnalyzerCore lldWasm
@@ -283,7 +283,7 @@ jobs:
283283
-DLLVM_EXTERNAL_CLING_SOURCE_DIR=../../cling `
284284
-DCMAKE_BUILD_TYPE=Release `
285285
-DLLVM_HOST_TRIPLE=wasm32-unknown-emscripten `
286-
-DLLVM_ENABLE_ASSERTIONS=ON `
286+
-DLLVM_ENABLE_ASSERTIONS=OFF `
287287
-DLLVM_TARGETS_TO_BUILD="${{ matrix.llvm_targets_to_build }}" `
288288
-DLLVM_ENABLE_LIBEDIT=OFF `
289289
-DLLVM_ENABLE_PROJECTS="${{ matrix.llvm_enable_projects }}" `
@@ -301,8 +301,8 @@ jobs:
301301
-DLLVM_BUILD_TOOLS=OFF `
302302
-DLLVM_ENABLE_LIBPFM=OFF `
303303
-DCLANG_BUILD_TOOLS=OFF `
304-
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0" `
305-
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0" `
304+
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" `
305+
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" `
306306
-DLLVM_ENABLE_LTO=Full `
307307
..\llvm
308308
emmake make clang cling lld gtest_main
@@ -327,7 +327,7 @@ jobs:
327327
echo "Apply clang${{ matrix.clang-runtime }}-*.patch patches:"
328328
emcmake cmake -DCMAKE_BUILD_TYPE=Release `
329329
-DLLVM_HOST_TRIPLE=wasm32-unknown-emscripten `
330-
-DLLVM_ENABLE_ASSERTIONS=ON `
330+
-DLLVM_ENABLE_ASSERTIONS=OFF `
331331
-DLLVM_TARGETS_TO_BUILD="${{ matrix.llvm_targets_to_build }}" `
332332
-DLLVM_ENABLE_LIBEDIT=OFF `
333333
-DLLVM_ENABLE_PROJECTS="${{ matrix.llvm_enable_projects }}" `
@@ -344,8 +344,8 @@ jobs:
344344
-DLLVM_BUILD_TOOLS=OFF `
345345
-DLLVM_ENABLE_LIBPFM=OFF `
346346
-DCLANG_BUILD_TOOLS=OFF `
347-
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0" `
348-
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0" `
347+
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" `
348+
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" `
349349
-DLLVM_ENABLE_LTO=Full `
350350
-G Ninja `
351351
..\llvm

‎Emscripten-build-instructions.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ mkdir build
8181
cd build
8282
emcmake cmake -DCMAKE_BUILD_TYPE=Release \
8383
-DLLVM_HOST_TRIPLE=wasm32-unknown-emscripten \
84-
-DLLVM_ENABLE_ASSERTIONS=ON \
84+
-DLLVM_ENABLE_ASSERTIONS=OFF \
8585
-DLLVM_TARGETS_TO_BUILD="WebAssembly" \
8686
-DLLVM_ENABLE_LIBEDIT=OFF \
8787
-DLLVM_ENABLE_PROJECTS="clang;lld" \
@@ -99,8 +99,8 @@ emcmake cmake -DCMAKE_BUILD_TYPE=Release \
9999
-DLLVM_ENABLE_LIBPFM=OFF \
100100
-DCLANG_BUILD_TOOLS=OFF \
101101
-DLLVM_NATIVE_TOOL_DIR=$NATIVE_DIR \
102-
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0" \
103-
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0" \
102+
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" \
103+
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" \
104104
-DLLVM_ENABLE_LTO=Full \
105105
../llvm
106106
emmake make libclang -j $(nproc --all)
@@ -115,7 +115,7 @@ mkdir build
115115
cd build
116116
emcmake cmake -DCMAKE_BUILD_TYPE=Release `
117117
-DLLVM_HOST_TRIPLE=wasm32-unknown-emscripten `
118-
-DLLVM_ENABLE_ASSERTIONS=ON `
118+
-DLLVM_ENABLE_ASSERTIONS=OFF `
119119
-DLLVM_TARGETS_TO_BUILD="WebAssembly" `
120120
-DLLVM_ENABLE_LIBEDIT=OFF `
121121
-DLLVM_ENABLE_PROJECTS="clang;lld" `
@@ -133,8 +133,8 @@ emcmake cmake -DCMAKE_BUILD_TYPE=Release `
133133
-DLLVM_ENABLE_LIBPFM=OFF `
134134
-DCLANG_BUILD_TOOLS=OFF `
135135
-G Ninja `
136-
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0" `
137-
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0" `
136+
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" `
137+
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" `
138138
-DLLVM_ENABLE_LTO=Full `
139139
..\llvm
140140
emmake ninja libclang clangInterpreter clangStaticAnalyzerCore lldWasm

‎docs/Emscripten-build-instructions.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ and osx
101101
cd build
102102
emcmake cmake -DCMAKE_BUILD_TYPE=Release \
103103
-DLLVM_HOST_TRIPLE=wasm32-unknown-emscripten \
104-
-DLLVM_ENABLE_ASSERTIONS=ON \
104+
-DLLVM_ENABLE_ASSERTIONS=OFF \
105105
-DLLVM_TARGETS_TO_BUILD="WebAssembly" \
106106
-DLLVM_ENABLE_LIBEDIT=OFF \
107107
-DLLVM_ENABLE_PROJECTS="clang;lld" \
@@ -119,8 +119,8 @@ and osx
119119
-DLLVM_ENABLE_LIBPFM=OFF \
120120
-DCLANG_BUILD_TOOLS=OFF \
121121
-DLLVM_NATIVE_TOOL_DIR=$NATIVE_DIR \
122-
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0" \
123-
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0" \
122+
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" \
123+
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" \
124124
-DLLVM_ENABLE_LTO=Full \
125125
../llvm
126126
emmake make libclang -j $(nproc --all)
@@ -135,7 +135,7 @@ or executing
135135
cd build
136136
emcmake cmake -DCMAKE_BUILD_TYPE=Release `
137137
-DLLVM_HOST_TRIPLE=wasm32-unknown-emscripten `
138-
-DLLVM_ENABLE_ASSERTIONS=ON `
138+
-DLLVM_ENABLE_ASSERTIONS=OFF `
139139
-DLLVM_TARGETS_TO_BUILD="WebAssembly" `
140140
-DLLVM_ENABLE_LIBEDIT=OFF `
141141
-DLLVM_ENABLE_PROJECTS="clang;lld" `
@@ -153,8 +153,8 @@ or executing
153153
-DLLVM_ENABLE_LIBPFM=OFF `
154154
-DCLANG_BUILD_TOOLS=OFF `
155155
-G Ninja `
156-
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0" `
157-
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0" `
156+
-DCMAKE_C_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" `
157+
-DCMAKE_CXX_FLAGS_RELEASE="-Oz -g0 -DNDEBUG" `
158158
-DLLVM_ENABLE_LTO=Full `
159159
..\llvm
160160
emmake ninja libclang clangInterpreter clangStaticAnalyzerCore lldWasm

0 commit comments

Comments
 (0)