Skip to content

Commit d60b546

Browse files
committed
Use node 22 for testing and update readme
1 parent 190caf6 commit d60b546

File tree

5 files changed

+35
-35
lines changed

5 files changed

+35
-35
lines changed

.github/workflows/deploy-github-page.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,16 @@ jobs:
6464
-DSYSROOT_PATH=$SYSROOT_PATH \
6565
-DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
6666
..
67-
emmake make -j ${{ env.ncpus }} check-xeus-cpp
67+
68+
micromamba create -n node-env -c conda-forge nodejs=22
69+
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
70+
71+
make check-xeus-cpp
6872
emmake make -j ${{ env.ncpus }} install
6973
7074
- name: Test Emscripten xeus-cpp in browser
7175
shell: bash -l {0}
7276
run: |
73-
set -e
74-
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus
75-
micromamba activate xeus-lite-host
7677
cd build/test
7778
# Fresh install browsers, and run Emscripten tests in them
7879
# This is to match the Emscripten build instructions, where
@@ -140,6 +141,8 @@ jobs:
140141
- name: Jupyter Lite integration
141142
shell: bash -l {0}
142143
run: |
144+
set -e
145+
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus -c conda-forge
143146
micromamba activate xeus-lite-host
144147
jupyter lite build \
145148
--XeusAddon.prefix=${{ env.PREFIX }} \

.github/workflows/main.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,6 @@ jobs:
191191
os: ubuntu-24.04
192192
- name: osx15-arm
193193
os: macos-15
194-
- name: osx26-arm
195-
os: macos-26
196194

197195
steps:
198196
- uses: actions/checkout@v5
@@ -238,16 +236,16 @@ jobs:
238236
-DSYSROOT_PATH=$SYSROOT_PATH \
239237
-DCMAKE_COMPILE_WARNING_AS_ERROR=ON \
240238
..
241-
emmake make -j ${{ env.ncpus }} check-xeus-cpp
239+
240+
micromamba create -n node-env -c conda-forge nodejs=22
241+
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
242+
243+
make check-xeus-cpp
242244
emmake make -j ${{ env.ncpus }} install
243245
244246
- name: Test Emscripten xeus-cpp in browser
245247
shell: bash -l {0}
246248
run: |
247-
export BUILD_PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-build
248-
set -e
249-
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyterlite-xeus
250-
micromamba activate xeus-lite-host
251249
cd build/test
252250
# Fresh install browsers, and run Emscripten tests in them
253251
# This is to match the Emscripten build instructions, where
@@ -320,6 +318,8 @@ jobs:
320318
- name: Jupyter Lite integration
321319
shell: bash -l {0}
322320
run: |
321+
set -e
322+
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyterlite-xeus -c conda-forge
323323
micromamba activate xeus-lite-host
324324
jupyter lite build --XeusAddon.prefix=${{ env.PREFIX }}
325325

CONTRIBUTING.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ micromamba create -f environment-wasm-build.yml -y
7474
micromamba activate xeus-cpp-wasm-build
7575
```
7676

77-
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following
77+
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Prefer using node 22 and above as prior versions lead to flaky test runs. Once the test pass, run the install command.
7878

7979
```bash
8080
micromamba create -f environment-wasm-host.yml --platform=emscripten-wasm32
@@ -91,7 +91,12 @@ emcmake cmake \
9191
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
9292
-DSYSROOT_PATH=$SYSROOT_PATH \
9393
..
94-
emmake make check-xeus-cpp
94+
95+
micromamba create -n node-env -c conda-forge nodejs=22
96+
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
97+
98+
make check-xeus-cpp
99+
emmake make install
95100
```
96101

97102
It is possible to run the Emscripten tests in a headless browser. We will run our tests in a fresh installed browser. Installing the browsers, and running the tests within the installed browsers will be platform dependent. To do this for Chrome and Firefox on MacOS execute the following
@@ -148,12 +153,6 @@ echo "Running test_xeus_cpp in Google Chrome"
148153
python $BUILD_PREFIX/bin/emrun.py --browser="google-chrome" --kill_exit --timeout 60 --browser-args="--headless --no-sandbox" test_xeus_cpp.html
149154
```
150155

151-
After you have checked that the kernel passes all the tests, you can install it by executing
152-
153-
```bash
154-
emmake make install
155-
```
156-
157156
To build and test Jupyter Lite with this kernel locally you can execute the following
158157
```bash
159158
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus -c conda-forge

README.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ micromamba create -f environment-wasm-build.yml -y
9090
micromamba activate xeus-cpp-wasm-build
9191
```
9292

93-
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following
93+
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Prefer using node 22 and above as prior versions lead to flaky test runs. Once the test pass, run the install command.
9494
```bash
9595
micromamba create -f environment-wasm-host.yml --platform=emscripten-wasm32
9696
mkdir build
@@ -106,7 +106,12 @@ emcmake cmake \
106106
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
107107
-DSYSROOT_PATH=$SYSROOT_PATH \
108108
..
109-
emmake make check-xeus-cpp
109+
110+
micromamba create -n node-env -c conda-forge nodejs=22
111+
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
112+
113+
make check-xeus-cpp
114+
emmake make install
110115
```
111116

112117
It is possible to run the Emscripten tests in a headless browser. We will run our tests in a fresh installed browser. Installing the browsers, and running the tests within the installed browsers will be platform dependent. To do this for Chrome and Firefox on MacOS execute the following
@@ -163,12 +168,6 @@ echo "Running test_xeus_cpp in Google Chrome"
163168
python $BUILD_PREFIX/bin/emrun.py --browser="google-chrome" --kill_exit --timeout 60 --browser-args="--headless --no-sandbox" test_xeus_cpp.html
164169
```
165170

166-
After you have checked that the kernel passes all the tests, you can install it by executing
167-
168-
```bash
169-
emmake make install
170-
```
171-
172171
To build and test Jupyter Lite with this kernel locally you can execute the following
173172
```bash
174173
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus -c conda-forge

docs/source/InstallationAndUsage.rst

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ the following
6868
micromamba create -f environment-wasm-build.yml -y
6969
micromamba activate xeus-cpp-wasm-build
7070
71-
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following
71+
You are now in a position to build the xeus-cpp kernel. You build and test it in node by executing the following. Prefer using node 22 and above as prior versions lead to flaky test runs. Once the test pass, run the install command.
7272

7373
.. code-block:: bash
7474
@@ -86,7 +86,12 @@ You are now in a position to build the xeus-cpp kernel. You build and test it in
8686
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
8787
-DSYSROOT_PATH=$SYSROOT_PATH \
8888
..
89-
emmake make check-xeus-cpp
89+
90+
micromamba create -n node-env -c conda-forge nodejs=22
91+
export PATH="$MAMBA_ROOT_PREFIX/envs/node-env/bin:$PATH"
92+
93+
make check-xeus-cpp
94+
emmake make install
9095
9196
It is possible to run the Emscripten tests in a headless browser. We will run our tests in a fresh installed browser. Installing the browsers, and running the tests within the installed browsers will be platform dependent. To do this for Chrome and Firefox on MacOS execute the following
9297

@@ -142,12 +147,6 @@ To do this on Ubuntu x86 execute the following
142147
echo "Running test_xeus_cpp in Google Chrome"
143148
python $BUILD_PREFIX/bin/emrun.py --browser="google-chrome" --kill_exit --timeout 60 --browser-args="--headless --no-sandbox" test_xeus_cpp.html
144149
145-
After you have checked that the kernel passes all the tests, you can install it by executing
146-
147-
.. code-block:: bash
148-
149-
emmake make install
150-
151150
To build and test Jupyter Lite with this kernel locally you can execute the following
152151

153152
.. code-block:: bash

0 commit comments

Comments
 (0)