Skip to content

Commit f2cfb8b

Browse files
committed
Fix faulty CMAKE_FIND_ROOT_PATH_MODE_PACKAGE being used for the wasm build
1 parent dc14222 commit f2cfb8b

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

.github/workflows/deploy-github-page.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,9 @@ jobs:
6363
6464
emcmake cmake \
6565
-DCMAKE_BUILD_TYPE=Release \
66-
-DCMAKE_PREFIX_PATH=$PREFIX \
6766
-DCMAKE_INSTALL_PREFIX=$PREFIX \
6867
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
69-
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
68+
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
7069
-DSYSROOT_PATH=$SYSROOT_PATH \
7170
..
7271
emmake make -j ${{ env.ncpus }} install

.github/workflows/main.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,10 +261,9 @@ jobs:
261261
262262
emcmake cmake \
263263
-DCMAKE_BUILD_TYPE=Release \
264-
-DCMAKE_PREFIX_PATH=$PREFIX \
265264
-DCMAKE_INSTALL_PREFIX=$PREFIX \
266265
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
267-
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
266+
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
268267
-DSYSROOT_PATH=$SYSROOT_PATH \
269268
..
270269
emmake make -j ${{ env.ncpus }} install

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,9 @@ export SYSROOT_PATH=$HOME/emsdk/upstream/emscripten/cache/sysroot
9191

9292
emcmake cmake \
9393
-DCMAKE_BUILD_TYPE=Release \
94-
-DCMAKE_PREFIX_PATH=$PREFIX \
9594
-DCMAKE_INSTALL_PREFIX=$PREFIX \
9695
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
97-
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
96+
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
9897
-DSYSROOT_PATH=$SYSROOT_PATH \
9998
..
10099
emmake make install

docs/source/InstallationAndUsage.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,9 @@ You are now in a position to build the xeus-cpp kernel. You build it by executin
7474
export SYSROOT_PATH=$HOME/emsdk/upstream/emscripten/cache/sysroot
7575
emcmake cmake \
7676
-DCMAKE_BUILD_TYPE=Release \
77-
-DCMAKE_PREFIX_PATH=$PREFIX \
7877
-DCMAKE_INSTALL_PREFIX=$PREFIX \
7978
-DXEUS_CPP_EMSCRIPTEN_WASM_BUILD=ON \
80-
-DCMAKE_FIND_ROOT_PATH_MODE_PACKAGE=ON \
79+
-DCMAKE_FIND_ROOT_PATH=$PREFIX \
8180
-DSYSROOT_PATH=$SYSROOT_PATH \
8281
..
8382
emmake make install

0 commit comments

Comments
 (0)