Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on [Bad Commit message] when --verbose argument is used to commit #89

Closed
joostsijm opened this issue Jan 31, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@joostsijm
Copy link

When the --verbose argument is used during commit, an exception occurs. The command git commit --verbose shows a DIFF of the changes being committed. The diff is separated from the commit message through the following few lines.

# ------------------------ >8 ------------------------
# Do not modify or remove the line above.
# Everything below it will be ignored.

I assume this case isn't included appropriately when parsing the commit message for valid use of conventions.

Reproducible with git commit with --verbose argument committing unsuccessful, and without argument successful.

@thekaveman thekaveman added the bug Something isn't working label Feb 13, 2024
@thekaveman
Copy link
Member

Thanks for the report @joostsijm! This is not a use-case I was aware of, so you are correct, this wasn't covered in parsing the commit message.

I would be happy to review a PR to fix this (please include some relevant tests as well!)

@thekaveman
Copy link
Member

Thanks for the report @joostsijm and the implementation @Ezri-Mudde!

Verbose commit messages are now supported in v3.2.0 which is available on PyPI: https://pypi.org/project/conventional-pre-commit/3.2.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants