Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tapir fails on 1.11 #180

Closed
gdalle opened this issue Jun 5, 2024 · 4 comments
Closed

Tapir fails on 1.11 #180

gdalle opened this issue Jun 5, 2024 · 4 comments
Labels
enhancement New feature or request high priority

Comments

@gdalle
Copy link

gdalle commented Jun 5, 2024

Heads up, I tried running the DI test suite on Julia 1.11-beta2, and Tapir failed

https://github.com/gdalle/DifferentiationInterface.jl/actions/runs/9378628896/job/25822187188?pr=302
@willtebbutt
Copy link
Member

Yup -- I think this is probably the same issue as #118 . With the changes to arrays in 1.11, we're going to need to update stuff in Tapir.jl. I'm going to close that issue in favour of this one.

@willtebbutt willtebbutt mentioned this issue Jun 5, 2024
Closed
@willtebbutt willtebbutt added the enhancement New feature or request label Jun 5, 2024
@yebai yebai mentioned this issue Jul 31, 2024
Open
@gdalle gdalle mentioned this issue Oct 8, 2024
Closed
@penelopeysm penelopeysm mentioned this issue Oct 8, 2024
Merged
@willtebbutt willtebbutt mentioned this issue Oct 9, 2024
Closed
@willtebbutt
Copy link
Member

willtebbutt commented Oct 19, 2024 •
edited
Loading

This should be resolved by #288 . Please re-open this if problems on v0.4.11 are not resolved.

@gdalle
Copy link
Author

gdalle commented Oct 20, 2024

Testing in JuliaDiff/DifferentiationInterface.jl#595

@willtebbutt willtebbutt reopened this Oct 20, 2024
@willtebbutt
Copy link
Member

I really must add those DI integration tests (although it looks like I didn't mess anything up this time haha).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yebai @willtebbutt @gdalle