Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slimmer require() #149

Open
tj opened this issue Jan 17, 2014 · 3 comments
Open

slimmer require() #149

tj opened this issue Jan 17, 2014 · 3 comments

Comments

@tj
Copy link
Contributor

tj commented Jan 17, 2014

@jonathanong not sure if you want to have a stab at moving your stuff over, I'll try and get to it when I have time but we all know how long that takes hahaha </3

@jonathanong
Copy link
Contributor

yeah i could. would rather not though haha easier just to rewrite the whole thing for me. i'm also not sure if it'll work as a plugin - maybe it will, just not as elegant. i also do two passes through the list of components, which doesn't really work in this plugin system. i'm -1 with all the 1 line functions (i find them difficult to understand) - those can all be resolved in a single pass.

@tj
Copy link
Contributor Author

tj commented Jan 17, 2014

one-line functions?

@jonathanong
Copy link
Contributor

yeah stuff like https://github.com/component/builder.js/blob/master/lib/plugins/commonjs.js#L195. i guess they are really called one-statement functions, but i guess there aren't as many anymore. some things are easier inlined since they don't make sense without the context haha

i'll work on my rewrite stuff this weekend, see how far we can get. maybe have a working component(1) implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants