Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file content is "undefined" if main.dependencies == boot.dependencies #8

Open
timaschew opened this issue Jun 9, 2014 · 0 comments

Comments

@timaschew
Copy link
Member

I ran into this issue, the result was:
a boot output with everything
and each pages output with: undefined

It should be an empty string, not undefined, throw an error, or show a warning?

I patched my bunderl.js/lib/page.js this way:

    // resolve boot bundles
    flatten(locals[boot])
    .forEach(function (branch) {
      branch.bundle = boot;
      var bootLocals = Object.keys(branch.locals);
      if (bootLocals.length > 0) {
        bootLocals.forEach(function (local) {
          if (bundles.indexOf(local) != -1)
            console.log('WARNING: dependency "'+local+'" is defined in both: root component and "'+branch.name+'"');
        });
      }
    });
@timaschew timaschew changed the title file content is "undefined" if root.dependencies == boot.dependencies file content is "undefined" if main.dependencies == boot.dependencies Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant