Skip to content
This repository was archived by the owner on Mar 27, 2019. It is now read-only.

'//@ sourceURL' is deprecated #348

Closed
micky2be opened this issue Jun 7, 2013 · 6 comments
Closed

'//@ sourceURL' is deprecated #348

micky2be opened this issue Jun 7, 2013 · 6 comments

Comments

@micky2be
Copy link
Contributor

micky2be commented Jun 7, 2013

Based on the V8 change log '//@ sourceURL' is deprecated.

https://code.google.com/p/v8/source/browse/trunk/ChangeLog#30

Added support for //# sourceURL similar to deprecated //@ sourceURL one

I guess we should think about updating the code to use '//# sourceURL' or both

@tj
Copy link
Contributor

tj commented Jun 18, 2013

hmm interesting!

@vendethiel
Copy link

this was changed for compat with oldIE (currently you have to use /* //@ sourceURL) but I'm not sure we should change it before it lands as a release (for both firefox and chrome)

@micky2be
Copy link
Contributor Author

It's something we should keep in mind for sure.
//# sourceURL has already been implemented in Google Canary 😉

@micky2be
Copy link
Contributor Author

Since it's more a builder problem I opened an issue in there
componentjs/builder.js#105

@sankargorthi
Copy link
Member

To add to this, can't load component build files with sourceUrls in IE10. When IE encounters //@ sourceURL=... it throws an error:

SCRIPT1004: Expected ';' 
build.js, line 1540 character 1

They're apparently [conditionally compiled statements](http://msdn.microsoft.com/en-us/library/ie/6s6fab9k(v=vs.94\).aspx). 😕

@jonathanong
Copy link
Contributor

cahnged to //# sourceURL in master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants