Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

randomReplicaID: Avoid require("crypto") #236

Closed
mweidner037 opened this issue Feb 12, 2023 · 1 comment
Closed

randomReplicaID: Avoid require("crypto") #236

mweidner037 opened this issue Feb 12, 2023 · 1 comment
Labels
minor This is not a priority, but would be nice to fix package:core core package

Comments

@mweidner037
Copy link
Collaborator

In randomReplicaID, we use Node's crypto library to get random bytes on NodeJS. Importing this library confuses Webpack even though it is only used on Node. Our current workaround uses eval("require"))("crypto"), but that causes warnings from Rollup. It would be nice to avoid these warnings.
@mweidner037 mweidner037 added minor This is not a priority, but would be nice to fix package:core core package labels Feb 12, 2023
@mweidner037
Copy link
Collaborator Author

webpack/webpack#8826

@mweidner037 mweidner037 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor This is not a priority, but would be nice to fix package:core core package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mweidner037